✓ CI.checkpatch: success for Have xe_vm and xe_exec_queue take references to xef (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Thu Jul 18 23:22:04 UTC 2024
== Series Details ==
Series: Have xe_vm and xe_exec_queue take references to xef (rev4)
URL : https://patchwork.freedesktop.org/series/135865/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
5ce3e132caaa5b45e5e50201b574a097d130967c
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 4eb765c5f2b7311a5afd7ffc9c1c7b55703ff66f
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Date: Thu Jul 18 14:05:48 2024 -0700
drm/xe: Fix use after free when client stats are captured
xe_file_close triggers an asynchronous queue cleanup and then frees up
the xef object. Since queue cleanup flushes all pending jobs and the KMD
stores client usage stats into the xef object after jobs are flushed, we
see a use-after-free for the xef object. Resolve this by taking a
reference to xef from xe_exec_queue.
While at it, revert an earlier change that contained a partial work
around for this issue.
v2:
- Take a ref to xef even for the VM bind queue (Matt)
- Squash patches relevant to that fix and work around (Lucas)
v3: Fix typo (Lucas)
Fixes: ce62827bc294 ("drm/xe: Do not access xe file when updating exec queue run_ticks")
Fixes: 6109f24f87d7 ("drm/xe: Add helper to accumulate exec queue runtime")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1908
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Reviewed-by: Matthew Brost <matthew.brost at intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch fb36109fa177ba6292b97812b973482491cd1fda drm-intel
fe28ed3f4c28 drm/xe: Move part of xe_file cleanup to a helper
0c5481119c96 drm/xe: Add ref counting for xe_file
2026aa361621 drm/xe: Take a ref to xe file when user creates a VM
4eb765c5f2b7 drm/xe: Fix use after free when client stats are captured
More information about the Intel-xe
mailing list