✓ CI.checkpatch: success for drm/xe: Fix warning on unreachable statement

Patchwork patchwork at emeril.freedesktop.org
Fri Jul 19 19:20:43 UTC 2024


== Series Details ==

Series: drm/xe: Fix warning on unreachable statement
URL   : https://patchwork.freedesktop.org/series/136300/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
5ce3e132caaa5b45e5e50201b574a097d130967c
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit beca55580ad2404a7fc936b4336ffeb260c47798
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Fri Jul 19 12:15:34 2024 -0700

    drm/xe: Fix warning on unreachable statement
    
    eu_type_to_str() relies on -Wswitch to warn (and -Werror) to make sure
    it handles all enum values. However it's perfectly legal to pass an int
    to that function so in the end that function may happen to return
    nothing. A smart compiler could notice eu_type is never assigned to
    anything other than those values.
    
    Trying to reproduce this issue, none of gcc-9, gcc-10 and gcc-13
    triggered for me, but this was reported in a different system with
    gcc-10:
    
            drivers/gpu/drm/xe/xe.o: warning: objtool: xe_gt_topology_dump() falls through to next function xe_gt_topology_init()
    
    Since that is not really possible, just take the simple approach and
    return NULL.
    
    Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch eb6045a759ea13e8d159bdaea423e904b9e3717b drm-intel
beca55580ad2 drm/xe: Fix warning on unreachable statement




More information about the Intel-xe mailing list