[PATCH 1/2] drm/xe: Delete unused register from xe_regs.h

[Upadhyay, Tejas]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Himal
> Prasad Ghimiray
> Sent: Monday, July 15, 2024 4:26 PM
> To: intel-xe at lists.freedesktop.org
> Cc: Ghimiray, Himal Prasad <himal.prasad.ghimiray at intel.com>; Wajdeczko,
> Michal <Michal.Wajdeczko at intel.com>
> Subject: [PATCH 1/2] drm/xe: Delete unused register from xe_regs.h
> 
> Register SOFTWARE_FLAGS_SPR33 is unused; therefore, delete it.
> 
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> ---
>  drivers/gpu/drm/xe/regs/xe_regs.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/regs/xe_regs.h
> b/drivers/gpu/drm/xe/regs/xe_regs.h
> index 55bf47c99016..dfa869f0dddd 100644
> --- a/drivers/gpu/drm/xe/regs/xe_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_regs.h
> @@ -15,8 +15,6 @@
>  #define GU_MISC_IRQ_OFFSET			0x444f0
>  #define   GU_MISC_GSE				REG_BIT(27)
> 
> -#define SOFTWARE_FLAGS_SPR33			XE_REG(0x4f084)

@De Marchi, Lucas I see you added specifically this register in below commit, was there any purpose ? To me it looks fine to remove.

commit 8cb49012ac171698b1253dea45e56c284e997d38
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Sat Feb 25 12:10:39 2023 -0800

    drm/xe: Do not spread i915_reg_defs.h include

    Reduce the use of i915_reg_defs.h so it can be encapsulated in a single
    place.

If no concerns from Lucas, then 
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

Thanks,
Tejas
> -
>  #define GU_CNTL_PROTECTED			XE_REG(0x10100C)
>  #define   DRIVERINT_FLR_DIS			REG_BIT(31)
> 
> --
> 2.34.1