✗ CI.checkpatch: warning for drm/xe: Add assert for XE_WA() usage (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 22 16:30:54 UTC 2024


== Series Details ==

Series: drm/xe: Add assert for XE_WA() usage (rev2)
URL   : https://patchwork.freedesktop.org/series/136146/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
5ce3e132caaa5b45e5e50201b574a097d130967c
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5ba4d48928f1f9eecabfba474e16b91d3636833c
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Mon Jul 22 09:06:39 2024 -0700

    drm/xe: Add assert for XE_WA() usage
    
    It's not always safe to call XE_WA() in the driver initialization. Add a
    xe_gt_assert() so this doesn't go unnoticed.
    
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 9f0593ea0093a0f5213c545e0651b5e100ef3526 drm-intel
5ba4d48928f1 drm/xe: Add assert for XE_WA() usage
-:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt__' - possible side-effects?
#58: FILE: drivers/gpu/drm/xe/xe_wa.h:30:
+#define XE_WA(gt__, id__) ({						\
+	xe_gt_assert(gt__, (gt__)->wa_active.oob_initialized);		\
+	test_bit(XE_WA_OOB_ ## id__, (gt__)->wa_active.oob);		\
+})

total: 0 errors, 0 warnings, 1 checks, 37 lines checked




More information about the Intel-xe mailing list