✗ CI.checkpatch: warning for drm/xe: Move VM dma-resv lock from xe_exec_queue_create to __xe_exec_queue_init
Patchwork
patchwork at emeril.freedesktop.org
Wed Jul 24 15:40:57 UTC 2024
== Series Details ==
Series: drm/xe: Move VM dma-resv lock from xe_exec_queue_create to __xe_exec_queue_init
URL : https://patchwork.freedesktop.org/series/136439/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
5ce3e132caaa5b45e5e50201b574a097d130967c
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 9569f1c0892eced31f2f2b32b4c91a84641b3d91
Author: Matthew Brost <matthew.brost at intel.com>
Date: Wed Jul 24 08:28:31 2024 -0700
drm/xe: Move VM dma-resv lock from xe_exec_queue_create to __xe_exec_queue_init
The critical section which requires the VM dma-resv is the call
xe_lrc_create in __xe_exec_queue_init. Move this lock to
__xe_exec_queue_init holding it just around xe_lrc_create. Not only is
good practice, this also fixes a locking double of the VM dma-resv in
the error paths of __xe_exec_queue_init as xe_lrc_put tries to acquire
this too resulting in a deadlock.
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Signed-off-by: Matthw Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch d3f0e5757ac089a2e31619da4452dfb3359803a0 drm-intel
9569f1c0892e drm/xe: Move VM dma-resv lock from xe_exec_queue_create to __xe_exec_queue_init
-:74: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: Matthew Brost <matthew.brost at intel.com>' != 'Signed-off-by: Matthw Brost <matthew.brost at intel.com>'
total: 0 errors, 1 warnings, 0 checks, 51 lines checked
More information about the Intel-xe
mailing list