[PATCH v2 0/7] Fix rtp when processing OOB workarounds

Lucas De Marchi lucas.demarchi at intel.com
Fri Jul 26 06:43:30 UTC 2024


Patch 5 is a quick fix for processing rtp entries that is used by
the OOB WAs, i.e. WAs without an action associated. Thanks Gustavo for
spotting the issue while browsing the code. This can be applied
independently of the rest.

Last patch is a refactor so it's more obvious what it's doing.

The rest of the patches improve the kunit tests so the bug described
would have been caught. Now the logic used by OOB WAs is also covered by
the kunit tests. If those tests are executed without the fix provided in
patch 5, the following errors appear:

	# xe_rtp_process_tests: EXPECTATION FAILED at drivers/gpu/drm/xe/tests/xe_rtp_test.c:494
	Expected active == param->expected_active, but
	    active == 30 (0x1e)
	    param->expected_active == 14 (0xe)
	[FAILED] inactive-1st_or_active-inactive
	# xe_rtp_process_tests: EXPECTATION FAILED at drivers/gpu/drm/xe/tests/xe_rtp_test.c:494
	Expected active == param->expected_active, but
	    active == 30 (0x1e)
	    param->expected_active == 14 (0xe)
	[FAILED] inactive-2nd_or_active-inactive
	# xe_rtp_process_tests: EXPECTATION FAILED at drivers/gpu/drm/xe/tests/xe_rtp_test.c:494
	Expected active == param->expected_active, but
	    active == 30 (0x1e)
	    param->expected_active == 14 (0xe)
	[FAILED] inactive-last_or_active-inactive
	[PASSED] inactive-no_or_active-inactive
	# xe_rtp_process_tests: pass:5 fail:3 skip:0 total:8
	============== [FAILED] xe_rtp_process_tests ===============
	    # module: xe_test
	# xe_rtp: pass:1 fail:1 skip:0 total:2
	# Totals: pass:16 fail:3 skip:0 total:19
	===================== [FAILED] xe_rtp ======================

With the fix, all of them pass.

v2:
  - Fix build due to missing change
  - Add tests for xe_rtp_process()

Lucas De Marchi (7):
  drm/xe/kunit: Test WAs for BMG
  drm/xe/kunit: Rename count to sr_entries
  drm/xe/kunit: Test active rtp entries
  drm/xe/kunit: Rename rtp test cases
  drm/xe/rtp: Fix off-by-one when processing rules
  drm/xe/kunit: Test rtp with no actions
  drm/xe/rtp: Simplify marking active workarounds

 drivers/gpu/drm/xe/tests/xe_rtp_test.c | 227 ++++++++++++++++++++++---
 drivers/gpu/drm/xe/tests/xe_wa_test.c  |   1 +
 drivers/gpu/drm/xe/xe_rtp.c            |  16 +-
 3 files changed, 213 insertions(+), 31 deletions(-)

-- 
2.43.0



More information about the Intel-xe mailing list