✗ CI.checkpatch: warning for Fix rtp when processing OOB workarounds (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Sat Jul 27 02:57:36 UTC 2024
== Series Details ==
Series: Fix rtp when processing OOB workarounds (rev4)
URL : https://patchwork.freedesktop.org/series/136538/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
5ce3e132caaa5b45e5e50201b574a097d130967c
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ee2c6cfae16c094e1b3e138936ecec25f4dd6bf1
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date: Fri Jul 26 18:59:07 2024 -0700
drm/xe: Migrate OOB WAs to OR rules
Now that rtp has OR rules, it's not needed to extend it to process OOB
WAs. Previously if an entry had no name, it was considered as "a set of
rules OR'ed with the last named entry".
Instead of generating new entries, add OR rules. The syntax for
xe_wa_oob.rules remains the same, with xe_gen_wa_oob generating the
slightly different table. Object sizes delta are negligible, but having
just one logic makes it easier to maintain:
add/remove: 0/0 grow/shrink: 1/2 up/down: 160/-269 (-109)
Function old new delta
__compound_literal 6104 6264 +160
xe_wa_dump 1839 1810 -29
oob_was 816 576 -240
Total: Before=17257, After=17148, chg -0.63%
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch e948842a6cba538c9f5f5dc8535a88d82a3fc0fe drm-intel
71c9c0be5f40 drm/xe/kunit: Test WAs for BMG
812a2ce78b9e drm/xe/kunit: Rename count to count_sr_entries
e66f1953ef8f drm/xe/kunit: Test active rtp entries
f113dd5253b3 drm/xe/kunit: Rename rtp test cases
232444888edd drm/xe/kunit: Test rtp with no actions
5c3ce4487d18 drm/xe/rtp: Simplify marking active workarounds
3878dd578a8d drm/xe/rtp: Expand max rules/actions per entry again
-:55: WARNING:LONG_LINE: line length of 165 exceeds 100 columns
#55: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:63:
+#define XE_RTP_PASTE_7(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_6(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:55: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#55: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:63:
+#define XE_RTP_PASTE_7(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_6(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#55: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:63:
+#define XE_RTP_PASTE_7(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_6(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#55: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:63:
+#define XE_RTP_PASTE_7(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_6(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:56: WARNING:LONG_LINE: line length of 165 exceeds 100 columns
#56: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:64:
+#define XE_RTP_PASTE_8(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_7(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:56: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#56: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:64:
+#define XE_RTP_PASTE_8(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_7(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#56: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:64:
+#define XE_RTP_PASTE_8(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_7(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#56: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:64:
+#define XE_RTP_PASTE_8(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_7(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:57: WARNING:LONG_LINE: line length of 165 exceeds 100 columns
#57: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:65:
+#define XE_RTP_PASTE_9(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_8(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:57: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#57: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:65:
+#define XE_RTP_PASTE_9(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_8(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#57: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:65:
+#define XE_RTP_PASTE_9(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_8(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#57: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:65:
+#define XE_RTP_PASTE_9(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_8(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:58: WARNING:LONG_LINE: line length of 166 exceeds 100 columns
#58: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:66:
+#define XE_RTP_PASTE_10(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_9(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:58: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#58: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:66:
+#define XE_RTP_PASTE_10(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_9(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#58: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:66:
+#define XE_RTP_PASTE_10(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_9(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#58: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:66:
+#define XE_RTP_PASTE_10(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_9(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:59: WARNING:LONG_LINE: line length of 167 exceeds 100 columns
#59: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:67:
+#define XE_RTP_PASTE_11(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_10(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:59: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#59: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:67:
+#define XE_RTP_PASTE_11(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_10(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:59: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#59: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:67:
+#define XE_RTP_PASTE_11(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_10(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:59: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#59: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:67:
+#define XE_RTP_PASTE_11(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_10(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:60: WARNING:LONG_LINE: line length of 167 exceeds 100 columns
#60: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:68:
+#define XE_RTP_PASTE_12(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_11(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:60: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#60: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:68:
+#define XE_RTP_PASTE_12(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_11(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:60: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#60: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:68:
+#define XE_RTP_PASTE_12(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_11(prefix_, sep_, _XE_TUPLE_TAIL args_)
-:60: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#60: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:68:
+#define XE_RTP_PASTE_12(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_11(prefix_, sep_, _XE_TUPLE_TAIL args_)
total: 6 errors, 6 warnings, 12 checks, 28 lines checked
ee2c6cfae16c drm/xe: Migrate OOB WAs to OR rules
More information about the Intel-xe
mailing list