✓ CI.checkpatch: success for drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll() (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 29 19:38:27 UTC 2024


== Series Details ==

Series: drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll() (rev2)
URL   : https://patchwork.freedesktop.org/series/136513/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
7b537a014c4c1a32250e342541870b03977fa7a4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d935c3ef1f8ebba5876ba7dc55c9e1509a6af06d
Author: Nikita Zhandarovich <n.zhandarovich at fintech.ru>
Date:   Mon Jul 29 10:40:35 2024 -0700

    drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()
    
    On the off chance that clock value ends up being too high (by means
    of skl_ddi_calculate_wrpll() having benn called with big enough
    value of crtc_state->port_clock * 1000), one possible consequence
    may be that the result will not be able to fit into signed int.
    
    Fix this issue by moving conversion of clock parameter from kHz to Hz
    into the body of skl_ddi_calculate_wrpll(), as well as casting the
    same parameter to u64 type while calculating the value for AFE clock.
    This both mitigates the overflow problem and avoids possible erroneous
    integer promotion mishaps.
    
    Found by Linux Verification Center (linuxtesting.org) with static
    analysis tool SVACE.
    
    Fixes: fe70b262e781 ("drm/i915: Move a bunch of stuff into rodata from the stack")
    Cc: stable at vger.kernel.org
    Signed-off-by: Nikita Zhandarovich <n.zhandarovich at fintech.ru>
+ /mt/dim checkpatch e64cee35967e4b08dd7f3b3ad6f110927c4699a9 drm-intel
d935c3ef1f8e drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()




More information about the Intel-xe mailing list