[PATCH] drm/xe/xe2hpg: Introduce performance tuning changes for Xe2_HPG

[Matt Roper]

On Thu, Jul 25, 2024 at 03:59:50PM -0300, Gustavo Sousa wrote:
> Quoting Sai Teja Pottumuttu (2024-07-24 09:15:21-03:00)
> >Add performance tuning changes for Xe2_HPG
> >
> >Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumuttu at intel.com>
> 
> I would add "Bspec: 72161" just before the s-o-b line.
> 
> >---
> > drivers/gpu/drm/xe/regs/xe_gt_regs.h | 1 +
> > drivers/gpu/drm/xe/xe_tuning.c       | 8 ++++++++
> > 2 files changed, 9 insertions(+)
> >
> >diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> >index 8a94a94d2267..3b87f95f9ecf 100644
> >--- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> >+++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> >@@ -108,6 +108,7 @@
> > 
> > #define FF_MODE                                        XE_REG_MCR(0x6210)
> > #define   DIS_TE_AUTOSTRIP                        REG_BIT(31)
> >+#define   VS_HIT_MAX_VALUE_MASK                        REG_GENMASK(25, 20)
> > #define   DIS_MESH_PARTIAL_AUTOSTRIP                REG_BIT(16)
> > #define   DIS_MESH_AUTOSTRIP                        REG_BIT(15)
> > 
> >diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
> >index d4e6fa918942..a8e1cfc99ed2 100644
> >--- a/drivers/gpu/drm/xe/xe_tuning.c
> >+++ b/drivers/gpu/drm/xe/xe_tuning.c
> >@@ -93,6 +93,14 @@ static const struct xe_rtp_entry_sr lrc_tunings[] = {
> >                                    REG_FIELD_PREP(L3_PWM_TIMER_INIT_VAL_MASK, 0x7f)))
> >         },
> > 
> >+        /* Xe2_HPG */
> >+
> >+        { XE_RTP_NAME("Tuning: vs hit max value"),
> >+          XE_RTP_RULES(GRAPHICS_VERSION(2001), ENGINE_CLASS(RENDER)),
> >+          XE_RTP_ACTIONS(FIELD_SET(FF_MODE, VS_HIT_MAX_VALUE_MASK,
> >+                                   REG_FIELD_PREP(VS_HIT_MAX_VALUE_MASK, 0x3F)))
> 
> We are using lowercase for hex values in this file.
> 
> The patch looks correct based on the specs. With the nitpicks addressed:
> 
>     Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>

Applied to drm-xe-next with the suggested tweaks.  Thanks for the patch
and review.


Matt

> 
> >+        },
> >+
> >         {}
> > };
> > 
> >-- 
> >2.34.1
> >

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation