[PATCH v3 0/6] Tracing cleanup and add mmio tracing

[Gustavo Sousa]

Quoting Radhakrishna Sripada (2024-05-30 12:13:07-03:00)
>xe_trace.h is getting bloated. Group related events to their own
>files. All bo, vm and vma related events have been moved to 
>xe_trace_bo.h. GuC related trace events have been moved to
>xe_trace_guc.h. Patches 1 and 2 splits the trace events into
>seperate files.
>
>In multi gpu environments, it is important to know the device from
>which the event was triggered. Print the device id information along
>with the trace information being printed. Patches 3, 4 and 5 make
>changes to print the device id's if not already captured.
>
>Mmio reg read writes are important tracing information that needs to be
>captured and will be helpful in display debug. Patch 6 adds the reg
>read/write tracing support.

As a general comment, I see that we are using dev_name() in multiple
places, at the call sites of the trace_*() functions.

Wouldn't it be cleaner (and maybe a tiny bit more efficient) if we just
had the trace event prototypes to receive the pointer to struct
xe_device and get the dev name inside TP_fast_assign()?

Another benefit of that approach is that it get easier to print more
xe-specific device info in the future if we feel like it.

--
Gustavo Sousa

>
>Earlier versions of patch 6 can be found here:
>v1: https://patchwork.freedesktop.org/series/119312/
>v2: https://patchwork.freedesktop.org/series/132626/
>
>Radhakrishna Sripada (6):
>  drm/xe/trace: Extract bo, vm, vma traces
>  drm/xe/trace: Extract guc related traces
>  drm/xe/trace: Print device_id in xe_trace_bo events
>  drm/xe/trace: Print device_id in xe_trace_guc events
>  drm/xe/trace: Print device_id in xe_trace events
>  drm/xe: Add reg read/write trace
>
> drivers/gpu/drm/xe/Makefile                 |   2 +
> drivers/gpu/drm/xe/xe_bo.c                  |   2 +-
> drivers/gpu/drm/xe/xe_gt_pagefault.c        |   2 +-
> drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c |  27 +-
> drivers/gpu/drm/xe/xe_guc_ct.c              |  15 +-
> drivers/gpu/drm/xe/xe_migrate.c             |   2 +-
> drivers/gpu/drm/xe/xe_mmio.c                |  22 +-
> drivers/gpu/drm/xe/xe_pt.c                  |   8 +-
> drivers/gpu/drm/xe/xe_trace.h               | 368 +++-----------------
> drivers/gpu/drm/xe/xe_trace_bo.c            |   9 +
> drivers/gpu/drm/xe/xe_trace_bo.h            | 244 +++++++++++++
> drivers/gpu/drm/xe/xe_trace_guc.c           |   9 +
> drivers/gpu/drm/xe/xe_trace_guc.h           | 107 ++++++
> drivers/gpu/drm/xe/xe_vm.c                  |   2 +-
> 14 files changed, 480 insertions(+), 339 deletions(-)
> create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.c
> create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.h
> create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.c
> create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.h
>
>-- 
>2.34.1
>