[PATCH 1/9] drm/xe/display: Always call xe_force_wake_put/get in pairs

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Tue Jun 4 11:41:25 UTC 2024



On 04-06-2024 16:32, Nirmoy Das wrote:
> xe_force_wake_get() increments the domain ref regardless of success or
> failure so call xe_force_wake_put() even on failure to keep ref count
> accurate.
> 
> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
> ---
>   drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> index 14b8b4278317..6cd82ef495c2 100644
> --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> @@ -56,8 +56,8 @@ bool intel_hdcp_gsc_check_status(struct xe_device *xe)
>   	if (!xe_gsc_proxy_init_done(&gt->uc.gsc))
>   		ret = false;
>   
> -	xe_force_wake_put(gt_to_fw(gt), XE_FW_GSC);
>   out:
> +	xe_force_wake_put(gt_to_fw(gt), XE_FW_GSC);

LGTM.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>

>   	xe_pm_runtime_put(xe);
>   	return ret;
>   }


More information about the Intel-xe mailing list