✗ CI.checkpatch: warning for drm/xe: Don't overmap identity VRAM mapping (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Jun 4 20:26:39 UTC 2024


== Series Details ==

Series: drm/xe: Don't overmap identity VRAM mapping (rev2)
URL   : https://patchwork.freedesktop.org/series/134282/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit fec6e01b749916568cb0a13af4c9627e57069635
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Mon Jun 3 11:18:24 2024 -0700

    drm/xe: Don't overmap identity VRAM mapping
    
    Overmapping the identity VRAM mapping is triggering hardware bugs on
    certain platforms. Use 2M pages for the last unaligned (to 1G) VRAM
    chunk.
    
    v2:
     - Always use 2M pages for last chunk (Fei Yang)
     - break loop when 2M pages are used
     - Add assert for usable_size being 2M aligned
    
    Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
    Cc: Fei Yang <fei.yang at intel.com>
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
    Reviewed-by: Fei Yang <fei.yang at intel.com>
+ /mt/dim checkpatch 596cf447db94909c4788fd612876520531e439b0 drm-intel
fec6e01b7499 drm/xe: Don't overmap identity VRAM mapping
-:43: WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#43: FILE: drivers/gpu/drm/xe/xe_migrate.c:144:
+	u64 entry, pt30_ofs;;

-:115: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#115: FILE: drivers/gpu/drm/xe/xe_migrate.c:292:
+				break;	/* Ensure pos == vram_limit assert correct */
+			} else {

total: 0 errors, 2 warnings, 0 checks, 105 lines checked




More information about the Intel-xe mailing list