[PATCH 0/9] Ensure xe_force_wake_put is always called after xe_force_wake_get

Lucas De Marchi lucas.demarchi at intel.com
Tue Jun 4 20:49:38 UTC 2024


On Tue, Jun 04, 2024 at 01:02:16PM GMT, Nirmoy Das wrote:
>Cuurently there is inconsistency how we handle force wake get and put
>calls. We have three cases:
>1 Return value of xe_force_wake_get is not checked.
>2 Return value of xe_force_wake_get is checked but continue.
>3 Return value of xe_force_wake_get is checked but the caller returns
>  without calling xe_force_wake_put.
>
>2nd case is perfectly valid but 1st and 3rd cases shouldn't happen. As
>xe_force_wake_get() will increment the ref count regardless of success
>or failure so xe_force_wake_get() should be followed by a
>xe_force_wake_put().

or rather xe_force_wake_get() should be fixed. Why does it increment the
refcount and at the same time return an error? 

Lucas De Marchi


More information about the Intel-xe mailing list