✗ CI.checkpatch: warning for drm/xe: Do not dereference NULL job->fence in trace points
Patchwork
patchwork at emeril.freedesktop.org
Wed Jun 5 07:26:46 UTC 2024
== Series Details ==
Series: drm/xe: Do not dereference NULL job->fence in trace points
URL : https://patchwork.freedesktop.org/series/134484/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d69fcb90589c2c83544f9a798a505f2bd4e5f8f5
Author: Matthew Brost <matthew.brost at intel.com>
Date: Tue Jun 4 22:50:41 2024 -0700
drm/xe: Do not dereference NULL job->fence in trace points
job->fence is not assigned until xe_sched_job_arm(), check for
job->fence in xe_sched_job_seqno() so any usage of this function (trace
points) do not result in NULL ptr dereference. Also check job->fence
before assigning error in job trace points.
Fixes: 0ac7a2c745e8 drm/xe: ("Don't initialize fences at xe_sched_job_create()")
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 596cf447db94909c4788fd612876520531e439b0 drm-intel
d69fcb90589c drm/xe: Do not dereference NULL job->fence in trace points
-:14: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: d69fcb90589c ("drm/xe: Do not dereference NULL job->fence in trace points")'
#14:
Fixes: 0ac7a2c745e8 drm/xe: ("Don't initialize fences at xe_sched_job_create()")
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
More information about the Intel-xe
mailing list