✓ CI.checkpatch: success for series starting with [v3,1/3] drm/xe: Cleanup force wake registers bit definitions
Patchwork
patchwork at emeril.freedesktop.org
Wed Jun 5 09:39:50 UTC 2024
== Series Details ==
Series: series starting with [v3,1/3] drm/xe: Cleanup force wake registers bit definitions
URL : https://patchwork.freedesktop.org/series/134491/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3a7f2e738d8462e79bbe60e750172f75a862cba5
Author: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
Date: Wed Jun 5 15:20:05 2024 +0530
drm/xe: Fix xe_force_wake_assert_held for enum XE_FORCEWAKE_ALL
xe_force_wake_assert_held is designed to trigger an assertion if the
provided domain is not awake, which works correctly for individual
domains. However, the assertion condition becomes incorrect for
XE_FORCEWAKE_ALL.
For instance, if we assume all domains are in sleep mode, invoking
xe_force_wake_get(fw, XE_FORCEWAKE_GT) will only awaken the "gt" domain.
Subsequently, another function needs that all domains are awake and
utilizes xe_force_wake_assert_held(fw, XE_FORCEWAKE_ALL).
In this scenario, the condition will inaccurately return success because
fw->awake_domains (0x1) & XE_FORCEWAKE_ALL (0xFF) will still be 0x1 and
Ideally it should have asserted.
Make sure that the assertion condition covers the wakefulness of all
initialized domains for XE_FORCEWAKE_ALL.
v2:
- %s/supported/initialized/
- update commit message (Rodrigo)
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Badal Nilawar <badal.nilawar at intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
Reviewed-by: Badal Nilawar <badal.nilawar at intel.com>
+ /mt/dim checkpatch 86626b17c77dab058258d6c46291764d39b51057 drm-intel
f7ac6850efde drm/xe: Cleanup force wake registers bit definitions
5add6e83b66f drm/xe: Add member initialized_domains to xe_force_wake
3a7f2e738d84 drm/xe: Fix xe_force_wake_assert_held for enum XE_FORCEWAKE_ALL
More information about the Intel-xe
mailing list