[RFC PATCH 1/5] drm/xe: Add LRC ctx timestamp support functions

Matthew Brost matthew.brost at intel.com
Fri Jun 7 15:16:10 UTC 2024


On Fri, Jun 07, 2024 at 10:10:54AM +0300, Jani Nikula wrote:
> On Thu, 06 Jun 2024, Matthew Brost <matthew.brost at intel.com> wrote:
> > +static inline u32 __xe_lrc_ctx_timestamp_job_offset(struct xe_lrc *lrc)
> 
> Please don't use the inline keyword in .c files, no matter how simple
> the function. Just let the compiler do its job of inlining as
> needed. Using inline also silences warnings about unused static
> functions.
> 

I'm aware of not using static inline in *.c file agree. This file has
thia design patch and actually doing this intentionally in a few spots,
so followew that design pattern. It use static inlines as some functions
spit out via magic macros are unused. Let me just clean this up so some
the functions spit out are annotated correctly...

Matt

> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel


More information about the Intel-xe mailing list