✗ CI.checkpatch: warning for Only timeout jobs if they run longer than timeout period

Patchwork patchwork at emeril.freedesktop.org
Sat Jun 8 00:25:25 UTC 2024


== Series Details ==

Series: Only timeout jobs if they run longer than timeout period
URL   : https://patchwork.freedesktop.org/series/134642/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 107c719d6355955d423aa91acbfb9d3b7a15f64b
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Fri Jun 7 17:21:03 2024 -0700

    drm/xe: Sample ctx timestamp to determine if jobs have timed out
    
    In GuC TDR sample ctx timestamp to determine if jobs have timed out. The
    scheduling enable needs to be toggled to properly sample the timestamp.
    If a job has not been running for longer than the timeout period,
    re-enable scheduling and restart the TDR.
    
    v2:
     - Use GT clock to msec helper (Umesh, off list)
     - s/ctx_timestamp_job/ctx_job_timestamp
    v3:
     - Fix state machine for TDR, mainly decouple sched disable and deregister (testing)
     - Rebase (CI)
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 2bea08bd31298d60d416b2a6ed346bb53dd28037 drm-intel
86153b6a388e drm/xe: Add LRC ctx timestamp support functions
229c3d3a0283 drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions
c36e5b54fa6f drm/xe: Emit ctx timestamp copy in ring ops
80d3505422f9 drm/xe: Add ctx timestamp to LRC snapshot
bd787e03d74e drm/xe: Add xe_gt_clock_interval_to_ms helper
107c719d6355 drm/xe: Sample ctx timestamp to determine if jobs have timed out
-:16: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#16: 
 - Fix state machine for TDR, mainly decouple sched disable and deregister (testing)

-:67: CHECK:SPACING: No space is necessary after a cast
#67: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:940:
+#define ADJUST_FIVE_PERCENT(__t)	(((__t) * 105) / 100)

-:67: ERROR:SPACING: space prohibited after that '*' (ctx:WxW)
#67: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:940:
+#define ADJUST_FIVE_PERCENT(__t)	(((__t) * 105) / 100)
                                 	        ^

-:308: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#308: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:1566:
+		if (((exec_queue_banned(q) || exec_queue_check_timeout(q))
+		    && exec_queue_destroyed(q)) ||

total: 1 errors, 1 warnings, 2 checks, 318 lines checked




More information about the Intel-xe mailing list