[PATCH v5 05/10] drm/xe: Add xe_gt_clock_interval_to_ms helper

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matthew Brost
Sent: Monday, June 10, 2024 7:18 AM
To: intel-xe at lists.freedesktop.org
Subject: [PATCH v5 05/10] drm/xe: Add xe_gt_clock_interval_to_ms helper
> 
> Add helper to convert GT clock ticks to msec. Useful for determining if
> timeouts occur by examing GT clock ticks.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_clock.c | 18 ++++++++++++++++++
>  drivers/gpu/drm/xe/xe_gt_clock.h |  1 +
>  2 files changed, 19 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_clock.c b/drivers/gpu/drm/xe/xe_gt_clock.c
> index 9ff2061133df..a9392a743fd5 100644
> --- a/drivers/gpu/drm/xe/xe_gt_clock.c
> +++ b/drivers/gpu/drm/xe/xe_gt_clock.c
> @@ -79,3 +79,21 @@ int xe_gt_clock_init(struct xe_gt *gt)
>  	gt->info.reference_clock = freq;
>  	return 0;
>  }
> +
> +static u64 div_u64_roundup(u64 nom, u32 den)

Nit: I think this should be "num" for "numerator" instead of "nom".
Or maybe just:
static u64 div_u64_roundup(u64 n, u64 d)
If "num" for numerator would be confused for "num" as in "number".

Otherwise:
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> +{
> +	return div_u64(nom + den - 1, den);
> +}
> +
> +/**
> + * xe_gt_clock_interval_to_ms - Convert sampled GT clock ticks to msec
> + *
> + * @gt: the &xe_gt
> + * @count: count of GT clock ticks
> + *
> + * Returns: time in msec
> + */
> +u64 xe_gt_clock_interval_to_ms(struct xe_gt *gt, u64 count)
> +{
> +	return div_u64_roundup(count * MSEC_PER_SEC, gt->info.reference_clock);
> +}
> diff --git a/drivers/gpu/drm/xe/xe_gt_clock.h b/drivers/gpu/drm/xe/xe_gt_clock.h
> index 44fa0371b973..3adeb7baaca4 100644
> --- a/drivers/gpu/drm/xe/xe_gt_clock.h
> +++ b/drivers/gpu/drm/xe/xe_gt_clock.h
> @@ -11,5 +11,6 @@
>  struct xe_gt;
>  
>  int xe_gt_clock_init(struct xe_gt *gt);
> +u64 xe_gt_clock_interval_to_ms(struct xe_gt *gt, u64 count);
>  
>  #endif
> -- 
> 2.34.1
> 
>