[PATCH v5 08/10] drm/xe: Add pending disable assert to handle_sched_done

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matthew Brost
Sent: Monday, June 10, 2024 7:18 AM
To: intel-xe at lists.freedesktop.org
Subject: [PATCH v5 08/10] drm/xe: Add pending disable assert to handle_sched_done
> 
> Will help catch bugs in GuC state machine.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>

LGTM
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index e697732f1e74..9e1535c2d8f3 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1607,6 +1607,8 @@ static void handle_sched_done(struct xe_guc *guc, struct xe_exec_queue *q)
>  		smp_wmb();
>  		wake_up_all(&guc->ct.wq);
>  	} else {
> +		xe_gt_assert(guc_to_gt(guc), exec_queue_pending_disable(q));
> +
>  		clear_exec_queue_pending_disable(q);
>  		if (q->guc->suspend_pending) {
>  			suspend_fence_signal(q);
> -- 
> 2.34.1
> 
>