[PATCH v5 09/10] drm/xe: Add killed, banned, or wedged as stick bit during GuC reset

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matthew Brost
Sent: Monday, June 10, 2024 7:18 AM
To: intel-xe at lists.freedesktop.org
Subject: [PATCH v5 09/10] drm/xe: Add killed, banned, or wedged as stick bit during GuC reset
> 
> These bits should be persistent across reset, treat them as such.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>

LGTM
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 9e1535c2d8f3..3db0aa40535d 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1444,7 +1444,9 @@ static void guc_exec_queue_stop(struct xe_guc *guc, struct xe_exec_queue *q)
>  		set_exec_queue_suspended(q);
>  		suspend_fence_signal(q);
>  	}
> -	atomic_and(EXEC_QUEUE_STATE_DESTROYED | EXEC_QUEUE_STATE_SUSPENDED,
> +	atomic_and(EXEC_QUEUE_STATE_WEDGED | EXEC_QUEUE_STATE_BANNED |
> +		   EXEC_QUEUE_STATE_KILLED | EXEC_QUEUE_STATE_DESTROYED |
> +		   EXEC_QUEUE_STATE_SUSPENDED,
>  		   &q->guc->state);
>  	q->guc->resume_time = 0;
>  	trace_xe_exec_queue_stop(q);
> -- 
> 2.34.1
> 
>