[PATCH v5 04/10] drm/xe: Add ctx timestamp to LRC snapshot

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matthew Brost
Sent: Monday, June 10, 2024 7:18 AM
To: intel-xe at lists.freedesktop.org
Subject: [PATCH v5 04/10] drm/xe: Add ctx timestamp to LRC snapshot
> 
> The ctx timestamp is useful information, add to LRC snapshot.
> 
> v2:
>   - s/ctx_timestamp_job/ctx_job_timestamp
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>

LGTM
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_lrc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index 0fef354c6489..f3d77aa1750d 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -49,6 +49,8 @@ struct xe_lrc_snapshot {
>  	} tail;
>  	u32 start_seqno;
>  	u32 seqno;
> +	u32 ctx_timestamp;
> +	u32 ctx_job_timestamp;
>  };
>  
>  static struct xe_device *
> @@ -1642,6 +1644,8 @@ struct xe_lrc_snapshot *xe_lrc_snapshot_capture(struct xe_lrc *lrc)
>  	snapshot->lrc_offset = xe_lrc_pphwsp_offset(lrc);
>  	snapshot->lrc_size = lrc->bo->size - snapshot->lrc_offset;
>  	snapshot->lrc_snapshot = NULL;
> +	snapshot->ctx_timestamp = xe_lrc_ctx_timestamp(lrc);
> +	snapshot->ctx_job_timestamp = xe_lrc_ctx_job_timestamp(lrc);
>  	return snapshot;
>  }
>  
> @@ -1690,6 +1694,8 @@ void xe_lrc_snapshot_print(struct xe_lrc_snapshot *snapshot, struct drm_printer
>  		   snapshot->tail.internal, snapshot->tail.memory);
>  	drm_printf(p, "\tStart seqno: (memory) %d\n", snapshot->start_seqno);
>  	drm_printf(p, "\tSeqno: (memory) %d\n", snapshot->seqno);
> +	drm_printf(p, "\tTimestamp: 0x%08x\n", snapshot->ctx_timestamp);
> +	drm_printf(p, "\tJob Timestamp: 0x%08x\n", snapshot->ctx_job_timestamp);
>  
>  	if (!snapshot->lrc_snapshot)
>  		return;
> -- 
> 2.34.1
> 
>