[PATCH v6 00/11] Only timeout jobs if they run longer than timeout period
Matthew Brost
matthew.brost at intel.com
Tue Jun 11 14:40:42 UTC 2024
Debugging [1] hit a known flaw in the job timeout mechanism - jobs
timeout after a period of time in which they have been submitted to the
GuC not how long they have actually been running on the hardware.
Attempt to fix this.
Algorithm is as follows:
- Copy ctx timestamp from LRC to saved location at beginning of every
job
- On TDR kick jobs off hardware via schedule disable so ctx timestamp is
updated
- Compare ctx timestamp to saved ctx timestamp, if jobs having been
running less than timeout period re-enable scheduling are restart TDR
New job cancel IGT [2] for testing.
v2:
- Promote to non-RFC as issues which I view as blockers have been resolved
- Address Jani and Michal v1 feedback
- Add GT clock timer calculation
v3:
- More testing
- Fix TDR state machine bugs exposed in testing
- Rebase for CI
v4:
- Address a few comments by John H
- Fix CI failure [3]
v5:
- Include all the patches
v6:
- Address John H's latest feedback including a new patch
- Fix CI hooks failure
- Fix assertion failure [4]
Matt
[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/799
[2] https://patchwork.freedesktop.org/series/134640/
[3] https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-134642v1/shard-dg2-433/igt@xe_exec_threads@threads-hang-fd-rebind.html
[4] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/799#note_2445590
Matthew Brost (11):
drm/xe: Add LRC ctx timestamp support functions
drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions
drm/xe: Emit ctx timestamp copy in ring ops
drm/xe: Add ctx timestamp to LRC snapshot
drm/xe: Add xe_gt_clock_interval_to_ms helper
drm/xe: Improve unexpected state error messages
drm/xe: Assert runnable state in handle_sched_done
drm/xe: Add GuC state asserts to deregister_exec_queue
drm/xe: Add pending disable assert to handle_sched_done
drm/xe: Add killed, banned, or wedged as stick bit during GuC reset
drm/xe: Sample ctx timestamp to determine if jobs have timed out
.../gpu/drm/xe/instructions/xe_mi_commands.h | 4 +
drivers/gpu/drm/xe/xe_gt_clock.c | 20 ++
drivers/gpu/drm/xe/xe_gt_clock.h | 1 +
drivers/gpu/drm/xe/xe_guc_submit.c | 334 ++++++++++++++----
drivers/gpu/drm/xe/xe_lrc.c | 84 ++++-
drivers/gpu/drm/xe/xe_lrc.h | 5 +
drivers/gpu/drm/xe/xe_ring_ops.c | 21 ++
7 files changed, 400 insertions(+), 69 deletions(-)
--
2.34.1
More information about the Intel-xe
mailing list