[PATCH v2 1/4] drm/xe: Prefer GT oriented messages in xe_force_wake.c

Lucas De Marchi lucas.demarchi at intel.com
Tue Jun 11 15:09:10 UTC 2024


On Tue, Jun 11, 2024 at 12:07:54PM GMT, Michal Wajdeczko wrote:
>If possible, we should prefer xe_gt_notice() over drm_notice().
>While at it, undo line split of fw_to_gt() function signature.
>
>Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>---
> drivers/gpu/drm/xe/xe_force_wake.c | 20 ++++++--------------
> 1 file changed, 6 insertions(+), 14 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c
>index b2d385daff4b..2497f0f65aa0 100644
>--- a/drivers/gpu/drm/xe/xe_force_wake.c
>+++ b/drivers/gpu/drm/xe/xe_force_wake.c
>@@ -10,22 +10,16 @@
> #include "regs/xe_gt_regs.h"
> #include "regs/xe_reg_defs.h"
> #include "xe_gt.h"
>+#include "xe_gt_printk.h"
> #include "xe_mmio.h"
>
> #define XE_FORCE_WAKE_ACK_TIMEOUT_MS	50
>
>-static struct xe_gt *
>-fw_to_gt(struct xe_force_wake *fw)
>+static struct xe_gt *fw_to_gt(struct xe_force_wake *fw)

unrelated change... but it doesn't seem we need this helper neither.
It should be perfect fine to just use fw->gt.

So I'd remove this hunk and in another patch remove the calls to fw_to_gt().

Lucas De Marchi


More information about the Intel-xe mailing list