[PATCH] drm/xe/irq: remove xe_irq_shutdown

Matthew Auld matthew.auld at intel.com
Tue Jun 11 16:22:08 UTC 2024


On 06/06/2024 13:47, Ilia Levi wrote:
> The cleanup is done by devres in irq_uninstall.
> 
> Commit bbc9651fe9f4 ("drm/xe/irq: move irq_uninstall over to devm")
> resolved the ordering issue where irq_uninstall (registered with drmm)
> was called after pci_free_irq_vectors (registered with devm upon calling
> pci_alloc_irq_vectors). This happened because drmm action list is
> registered with devm very early in the init flow - before
> pci_alloc_irq_vectors.
> 
> Now that irq_uninstall is registered with devm, it will be called before
> pci_free_irq_vectors and we can remove xe_irq_shutdown.
> 
> Signed-off-by: Ilia Levi <illevi at habana.ai>
Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-xe mailing list