✗ CI.checkpatch: warning for drm/xe/pmu: Enable PMU interface (rev8)

Patchwork patchwork at emeril.freedesktop.org
Wed Jun 12 05:33:35 UTC 2024


== Series Details ==

Series: drm/xe/pmu: Enable PMU interface (rev8)
URL   : https://patchwork.freedesktop.org/series/119504/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 34b3e6578bc0f7c5e725cae01523109656ba38dc
Author: Aravind Iddamsetty <aravind.iddamsetty at linux.intel.com>
Date:   Wed Jun 12 11:10:33 2024 +0530

    drm/xe/pmu: Enable PMU interface
    
    There are a set of engine group busyness counters provided by HW which are
    perfect fit to be exposed via PMU perf events.
    
    BSPEC: 46559, 46560, 46722, 46729, 52071, 71028
    
    events can be listed using:
    perf list
      xe_0000_03_00.0/any-engine-group-busy-gt0/         [Kernel PMU event]
      xe_0000_03_00.0/copy-group-busy-gt0/               [Kernel PMU event]
      xe_0000_03_00.0/interrupts/                        [Kernel PMU event]
      xe_0000_03_00.0/media-group-busy-gt0/              [Kernel PMU event]
      xe_0000_03_00.0/render-group-busy-gt0/             [Kernel PMU event]
    
    and can be read using:
    
    perf stat -e "xe_0000_8c_00.0/render-group-busy-gt0/" -I 1000
               time        counts unit events
         1.001139062            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         2.003294678            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         3.005199582            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         4.007076497            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         5.008553068            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         6.010531563        43520 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         7.012468029        44800 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         8.013463515            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
         9.015300183            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
        10.017233010            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
        10.971934120            0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
    
    The pmu base implementation is taken from i915.
    
    v2:
    Store last known value when device is awake return that while the GT is
    suspended and then update the driver copy when read during awake.
    
    v3:
    1. drop init_samples, as storing counters before going to suspend should
    be sufficient.
    2. ported the "drm/i915/pmu: Make PMU sample array two-dimensional" and
    dropped helpers to store and read samples.
    3. use xe_device_mem_access_get_if_ongoing to check if device is active
    before reading the OA registers.
    4. dropped format attr as no longer needed
    5. introduce xe_pmu_suspend to call engine_group_busyness_store
    6. few other nits.
    
    v4: minor nits.
    
    v5: take forcewake when accessing the OAG registers
    
    v6:
    1. drop engine_busyness_sample_type
    2. update UAPI documentation
    
    v7:
    1. update UAPI documentation
    2. drop MEDIA_GT specific change for media busyness counter.
    
    v8:
    1. rebase
    2. replace mem_access_if_ongoing with xe_pm_runtime_get_if_active
    3. remove interrupts pmu event
    
    Co-developed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Co-developed-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
    Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
    Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty at linux.intel.com>
    Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
    Signed-off-by: Riana Tauro <riana.tauro at intel.com>
+ /mt/dim checkpatch 1340288da1f2a87e92a52d4e86a7247e4687bd62 drm-intel
5626533b28d1 drm/xe: Get GT clock to nanosecs
34b3e6578bc0 drm/xe/pmu: Enable PMU interface
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:178: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#178: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 837 lines checked




More information about the Intel-xe mailing list