✓ CI.checkpatch: success for drm/xe: Fix missing runtime outer protection for ggtt_remove_node (rev7)

Patchwork patchwork at emeril.freedesktop.org
Fri Jun 14 19:40:43 UTC 2024


== Series Details ==

Series: drm/xe: Fix missing runtime outer protection for ggtt_remove_node (rev7)
URL   : https://patchwork.freedesktop.org/series/134308/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f41a27cddfca189a9fa203df1fe0133e5d95ef6a
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date:   Fri Jun 14 14:37:58 2024 -0400

    drm/xe: Fix missing runtime outer protection for ggtt_remove_node
    
    Defer the ggtt node removal to a thread if runtime_pm is not active.
    
    The ggtt node removal can be called from multiple places, including
    places where we cannot protect with outer callers and places we are
    within other locks. So, try to grab the runtime reference if the
    device is already active, otherwise defer the removal to a separate
    thread from where we are sure we can wake the device up.
    
    v2: - use xe wq instead of system wq (Matt and CI)
        - Avoid GFP_KERNEL to be future proof since this removal can
        be called from outside our drivers and we don't want to block
        if atomic is needed. (Brost)
    v3: amend forgot chunk declaring xe_device.
    v4: Use a xe_ggtt_region to encapsulate the node and remova info,
        wihtout the need for any memory allocation at runtime.
    v5: Actually fill the delayed_removal.invalidate (Brost)
    v6: - Ensure that ggtt_region is not freed before work finishes (Auld)
        - Own wq to ensures that the queued works are flushed before
          ggtt_fini (Brost)
    v7: also free ggtt_region on early !bound return (Auld)
    
    Cc: Matthew Auld <matthew.auld at intel.com>
    Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
    Cc: Francois Dugast <francois.dugast at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Reviewed-by: Matthew Brost <matthew.brost at intel.com>
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 5c623c9712af3170cc9782a10ed7360ddf8f8bb4 drm-intel
f41a27cddfca drm/xe: Fix missing runtime outer protection for ggtt_remove_node




More information about the Intel-xe mailing list