[CI 34/44] drm/xe/svm: implement functions to allocate and free device memory
Oak Zeng
oak.zeng at intel.com
Fri Jun 14 21:58:07 UTC 2024
Function xe_svm_alloc_pages allocate pages from drm buddy and perform
house keeping work for all the pages allocated, such as get a page
refcount, set page's zone_device_data to point to the drm buddy block
that the page belongs to.
Function xe_svm_free_page free one page back to drm buddy allocator.
v1: Drop buddy block meta data (Matt)
Take vram_mgr->lock during buddy operation (Matt)
Moving to page granularity memory free (Oak)
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: Thomas Hellström <thomas.hellstrom at intel.com>
Cc: Brian Welty <brian.welty at intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
Cc: Matthew Auld <matthew.auld at intel.com>
Co-developed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
Signed-off-by: Oak Zeng <oak.zeng at intel.com>
---
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/xe_svm.c | 148 ++++++++++++++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_svm.h | 16 ++++
3 files changed, 165 insertions(+)
create mode 100644 drivers/gpu/drm/xe/xe_svm.c
create mode 100644 drivers/gpu/drm/xe/xe_svm.h
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index b30b70b7213f..3b59d7cb58e9 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -108,6 +108,7 @@ xe-y += xe_bb.o \
xe_sa.o \
xe_sched_job.o \
xe_step.o \
+ xe_svm.o \
xe_sync.o \
xe_tile.o \
xe_tile_sysfs.o \
diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
new file mode 100644
index 000000000000..a64dbbdff1ae
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_svm.c
@@ -0,0 +1,148 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#include <linux/mm_types.h>
+#include <linux/sched/mm.h>
+#include <linux/gfp.h>
+#include <drm/drm_buddy.h>
+#include "xe_ttm_vram_mgr_types.h"
+#include "xe_device_types.h"
+#include "xe_device.h"
+#include "xe_tile.h"
+#include "xe_svm.h"
+#include "xe_assert.h"
+
+/** This is a placeholder for compilation. Will introduce function to drm buddy */
+static void drm_buddy_block_free_subrange(struct drm_buddy_block *block, u64 start,
+ u64 end, struct list_head *block_list)
+{
+}
+
+static u64 block_offset_to_pfn(struct xe_mem_region *mr, u64 offset)
+{
+ /** DRM buddy's block offset is 0-based*/
+ offset += mr->drm_mr.hpa_base;
+
+ return PHYS_PFN(offset);
+}
+
+void xe_svm_free_page(struct page *page)
+{
+ struct drm_buddy_block *block =
+ (struct drm_buddy_block *)page->zone_device_data;
+ struct drm_mem_region *mr = drm_page_to_mem_region(page);
+ struct xe_mem_region *xe_mr = container_of(mr, struct xe_mem_region, drm_mr);
+ struct xe_tile *tile = xe_mem_region_to_tile(xe_mr);
+ struct drm_buddy *mm = &tile->mem.vram_mgr->mm;
+ u64 size = drm_buddy_block_size(mm, block);
+ u64 pages_per_block = size >> PAGE_SHIFT;
+ u64 block_pfn_first =
+ block_offset_to_pfn(xe_mr, drm_buddy_block_offset(block));
+ u64 page_pfn = page_to_pfn(page);
+ u64 page_idx = page_pfn - block_pfn_first;
+ struct list_head blocks = LIST_HEAD_INIT(blocks);
+ struct drm_buddy_block *tmp;
+ int i;
+
+ xe_assert(tile->xe, page_idx < pages_per_block);
+ drm_buddy_block_free_subrange(block, page_idx << PAGE_SHIFT,
+ (page_idx << PAGE_SHIFT) + PAGE_SIZE, &blocks);
+
+ /**
+ * page's buddy_block (record in page's zone_device_data) is changed
+ * due to above partial free. update zone_device_data.
+ */
+ list_for_each_entry_safe(block, tmp, &blocks, link) {
+ size = drm_buddy_block_size(mm, block);
+ pages_per_block = size >> PAGE_SHIFT;
+ block_pfn_first =
+ block_offset_to_pfn(xe_mr, drm_buddy_block_offset(block));
+ for (i = 0; i < pages_per_block; i++) {
+ struct page *p;
+
+ p = pfn_to_page(block_pfn_first + i);
+ p->zone_device_data = block;
+ }
+ }
+}
+
+/**
+ * __free_blocks() - free all memory blocks
+ *
+ * @mm: drm_buddy that the blocks belongs to
+ * @blocks: memory blocks list head
+ */
+static void __free_blocks(struct drm_buddy *mm, struct list_head *blocks)
+{
+ struct drm_buddy_block *block, *tmp;
+
+ list_for_each_entry_safe(block, tmp, blocks, link)
+ drm_buddy_free_block(mm, block);
+}
+
+/**
+ * xe_svm_alloc_pages() - allocate device pages from buddy allocator
+ *
+ * @mr: which memory region to allocate device memory from
+ * @npages: how many pages to allocate
+ * @pfn: used to return the pfn of all allocated pages. Must be big enough
+ * to hold at @npages entries.
+ *
+ * This function allocate blocks of memory from drm buddy allocator, and
+ * performs initialization work: set struct page::zone_device_data to point
+ * to the memory block; zone_device_page_init each page allocated; add pages
+ * to lru managers lru list for eviction purpose - this is TBD.
+ *
+ * return: 0 on success
+ * error code otherwise
+ */
+int xe_svm_alloc_pages(struct drm_mem_region *mr,
+ unsigned long npages, unsigned long *pfn)
+{
+ struct xe_mem_region *xe_mr = container_of(mr, struct xe_mem_region, drm_mr);
+ struct xe_tile *tile = xe_mem_region_to_tile(xe_mr);
+ struct drm_buddy *mm = &tile->mem.vram_mgr->mm;
+ struct drm_buddy_block *block, *tmp;
+ u64 size = npages << PAGE_SHIFT;
+ int ret = 0, i, j = 0;
+ struct list_head blocks;
+
+ mutex_lock(&tile->mem.vram_mgr->lock);
+ ret = drm_buddy_alloc_blocks(mm, 0, mm->size, size, PAGE_SIZE,
+ &blocks, DRM_BUDDY_CONTIGUOUS_ALLOCATION);
+
+ if (unlikely(ret)) {
+ mutex_unlock(&tile->mem.vram_mgr->lock);
+ return ret;
+ }
+
+ ret = drm_buddy_block_trim(mm, size, &blocks);
+ if (ret) {
+ __free_blocks(mm, &blocks);
+ mutex_unlock(&tile->mem.vram_mgr->lock);
+ return ret;
+ }
+ mutex_unlock(&tile->mem.vram_mgr->lock);
+
+ list_for_each_entry_safe(block, tmp, &blocks, link) {
+ u64 block_pfn_first, pages_per_block;
+
+ size = drm_buddy_block_size(mm, block);
+ pages_per_block = size >> PAGE_SHIFT;
+ block_pfn_first =
+ block_offset_to_pfn(xe_mr, drm_buddy_block_offset(block));
+ for (i = 0; i < pages_per_block; i++) {
+ struct page *page;
+
+ pfn[j++] = block_pfn_first + i;
+ page = pfn_to_page(block_pfn_first + i);
+ /**Lock page per hmm requirement, see hmm.rst.*/
+ zone_device_page_init(page);
+ page->zone_device_data = block;
+ }
+ }
+
+ return ret;
+}
diff --git a/drivers/gpu/drm/xe/xe_svm.h b/drivers/gpu/drm/xe/xe_svm.h
new file mode 100644
index 000000000000..2ed3ba240cb1
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_svm.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+#ifndef _XE_SVM_
+#define _XE_SVM_
+
+struct drm_mem_region;
+struct page;
+
+int xe_svm_alloc_pages(struct drm_mem_region *mr,
+ unsigned long npages, unsigned long *pfn);
+void xe_svm_free_page(struct page *page);
+
+#endif
--
2.26.3
More information about the Intel-xe
mailing list