✗ CI.checkpatch: warning for drm/i915: PREEMPT_RT related fixups. (rev4)

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 17 10:12:36 UTC 2024


== Series Details ==

Series: drm/i915: PREEMPT_RT related fixups. (rev4)
URL   : https://patchwork.freedesktop.org/series/132082/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 8903c9255815b578d3bf10af351d50ac7a6fd3c5
Author: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
Date:   Thu Jun 13 12:20:25 2024 +0200

    Revert "drm/i915: Depend on !PREEMPT_RT."
    
    Once the known issues are addressed, it should be safe to enable the
    driver.
    
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
+ /mt/dim checkpatch 62b6355cedf3a3429355ea4b4073d85dfaff8e42 drm-intel
edaf1c908d44 drm/i915: Use preempt_disable/enable_rt() where recommended
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
  ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into kms driver.")

total: 0 errors, 1 warnings, 0 checks, 67 lines checked
9fd03ebc591a drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates
-:10: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10: 
started disabling interrupts across atomic updates. This breaks on PREEMPT_RT

total: 0 errors, 1 warnings, 0 checks, 42 lines checked
2d1d2f1349a7 drm/i915: Don't check for atomic context on PREEMPT_RT
-:10: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10: 
> > If so would cant_migrate() work? It requires CONFIG_DEBUG_ATOMIC_SLEEP=y

total: 0 errors, 1 warnings, 0 checks, 15 lines checked
c733d60b6bb4 drm/i915: Disable tracing points on PREEMPT_RT
-:26: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#26: 
Reported-by: Luca Abeni <lucabe72 at gmail.com>
Cc: Steven Rostedt <rostedt at goodmis.org>

total: 0 errors, 1 warnings, 0 checks, 20 lines checked
9b8a773140c6 drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()
-:22: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#22: 
Reported-by: Clark Williams <williams at redhat.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>

total: 0 errors, 1 warnings, 0 checks, 53 lines checked
adff0f88879a drm/i915: Drop the irqs_disabled() check
-:16: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#16: 
Reported-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>

total: 0 errors, 1 warnings, 0 checks, 14 lines checked
34c182b18892 drm/i915/guc: Consider also RCU depth in busy loop.
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#13: 
Reported-by: "John B. Wyatt IV" <jwyatt at redhat.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

-:26: ERROR:IN_ATOMIC: do not use in_atomic in drivers
#26: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc.h:365:
+	bool not_atomic = !in_atomic() && !irqs_disabled() && !rcu_preempt_depth();

total: 1 errors, 1 warnings, 0 checks, 8 lines checked
8903c9255815 Revert "drm/i915: Depend on !PREEMPT_RT."




More information about the Intel-xe mailing list