✗ CI.checkpatch: warning for drm/xe/rtp: Allow to OR rules (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Jun 18 05:06:33 UTC 2024


== Series Details ==

Series: drm/xe/rtp: Allow to OR rules (rev2)
URL   : https://patchwork.freedesktop.org/series/134967/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 475ea5190aabe7c1dfeff023fe86bf74b8a5304a
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Mon Jun 17 22:00:44 2024 -0700

    drm/xe/xe2: Add proper check for media in Wa_14020756599
    
    A temporary fixup was made in commit 24d0d98af1c3 ("drm/xe/xe2lpm: Fixup
    Wa_14020756599") due to limitations in the RTP infra. Now that RTP has
    support for OR condition that change can be removed. RTP now also
    supports checking any GT, so use that instead of the more specific
    xe_rtp_match_when_media2000() used in that commit.
    
    Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 7f26b37f8cb73f5cf2251d7fff5b55240e04f153 drm-intel
723d60bbffdb drm/xe/rtp: Allow to match 0 sr entries
730a6a068199 drm/xe/rtp: Expand max rules/actions per entry
-:43: WARNING:LONG_LINE: line length of 165 exceeds 100 columns
#43: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:61:
+#define XE_RTP_PASTE_5(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_4(prefix_, sep_, _XE_TUPLE_TAIL args_)

-:43: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#43: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:61:
+#define XE_RTP_PASTE_5(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_4(prefix_, sep_, _XE_TUPLE_TAIL args_)

-:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#43: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:61:
+#define XE_RTP_PASTE_5(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_4(prefix_, sep_, _XE_TUPLE_TAIL args_)

-:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#43: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:61:
+#define XE_RTP_PASTE_5(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_4(prefix_, sep_, _XE_TUPLE_TAIL args_)

-:44: WARNING:LONG_LINE: line length of 165 exceeds 100 columns
#44: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:62:
+#define XE_RTP_PASTE_6(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_5(prefix_, sep_, _XE_TUPLE_TAIL args_)

-:44: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#44: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:62:
+#define XE_RTP_PASTE_6(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_5(prefix_, sep_, _XE_TUPLE_TAIL args_)

-:44: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'prefix_' - possible side-effects?
#44: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:62:
+#define XE_RTP_PASTE_6(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_5(prefix_, sep_, _XE_TUPLE_TAIL args_)

-:44: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'args_' - possible side-effects?
#44: FILE: drivers/gpu/drm/xe/xe_rtp_helpers.h:62:
+#define XE_RTP_PASTE_6(prefix_, sep_, args_) _XE_RTP_CONCAT(prefix_, FIRST_ARG args_) __XE_RTP_PASTE_SEP_ ## sep_ XE_RTP_PASTE_5(prefix_, sep_, _XE_TUPLE_TAIL args_)

total: 2 errors, 2 warnings, 4 checks, 24 lines checked
273627704010 drm/xe/rtp: Allow to OR rules
01c49eab5582 drm/xe/rtp: Add match on any GT
475ea5190aab drm/xe/xe2: Add proper check for media in Wa_14020756599




More information about the Intel-xe mailing list