✗ CI.checkpatch: warning for TTM shrinker helpers and xe buffer object shrinker (rev5)

Patchwork patchwork at emeril.freedesktop.org
Tue Jun 18 07:24:48 UTC 2024


== Series Details ==

Series: TTM shrinker helpers and xe buffer object shrinker (rev5)
URL   : https://patchwork.freedesktop.org/series/131815/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 7cfc6e4e1251e3368a3dc0eca71f304225442e1f
Author: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Date:   Tue Jun 18 09:18:20 2024 +0200

    drm/xe: Increase the XE_PL_TT watermark
    
    The XE_PL_TT watermark was set to 50% of system memory.
    The idea behind that was unclear since the net effect is that
    TT memory will be evicted to TTM_PL_SYSTEM memory if that
    watermark is exceeded, requiring PPGTT rebinds and dma
    remapping. But there is no similar watermark for TTM_PL_SYSTEM
    memory.
    
    The TTM functionality that tries to swap out system memory to
    shmem objects if a 50% limit of total system memory is reached
    is orthogonal to this, and with the shrinker added, it's no
    longer in effect.
    
    Replace the 50% TTM_PL_TT limit with a 100% limit, in effect
    allowing all graphics memory to be bound to the device unless it
    has been swapped out by the shrinker.
    
    Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
+ /mt/dim checkpatch 7f26b37f8cb73f5cf2251d7fff5b55240e04f153 drm-intel
49ecc66313ea drm/ttm: Allow TTM LRU list nodes of different types
e7166a74cbd6 drm/ttm: Slightly clean up LRU list iteration
89b63b65fb7c drm/ttm: Use LRU hitches
bee0fabb68a6 drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves
fcce5b8760ca drm/ttm: Provide a generic LRU walker helper
2167a789e491 drm/ttm: Use the LRU walker helper for swapping
2267642a0b6f drm/ttm: Use the LRU walker for eviction
9308c9bcc8f2 drm/ttm: Add a virtual base class for graphics memory backup
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 283 lines checked
18dc0654d2df drm/ttm/pool: Provide a helper to shrink pages
278906161ced drm/ttm: Use fault-injection to test error paths
-:28: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully describes the config symbol
#28: FILE: drivers/gpu/drm/Kconfig:275:
+config DRM_TTM_BACKUP_FAULT_INJECT
+	bool "Enable fault injection during TTM backup"
+	depends on DRM_TTM
+	default n
+	help
+	  Inject recoverable failures during TTM backup and recovery of
+	  backed-up objects. For DRM driver developers only.
+
+	  If in doubt, choose N.
+

total: 0 errors, 1 warnings, 0 checks, 51 lines checked
c0403ba51303 drm/ttm, drm/xe: Add a shrinker for xe bos
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:168: CHECK:SPACING: No space is necessary after a cast
#168: FILE: drivers/gpu/drm/xe/tests/xe_bo.c:382:
+		   (unsigned long) total);

-:677: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#677: 
new file mode 100644

total: 0 errors, 1 warnings, 1 checks, 891 lines checked
7cfc6e4e1251 drm/xe: Increase the XE_PL_TT watermark




More information about the Intel-xe mailing list