[PATCH v2] drm/xe/oa: Fix kernel doc warnings in xe_drm.h

Ashutosh Dixit ashutosh.dixit at intel.com
Sat Jun 22 15:59:18 UTC 2024


Fix kernel doc warnings in xe_drm.h. Also make sure that private/non-abi
enum definitions are distinct from real enum definitions and don't generate
kernel doc.

v2: Remove __DRM_XE_PERF_TYPE_MAX since it is unused (Michal)

Suggested-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
---
 drivers/gpu/drm/xe/xe_oa.c | 2 +-
 include/uapi/drm/xe_drm.h  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index 4168b51cf7b5..fe6e29fb06b7 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -1692,7 +1692,7 @@ static int xe_oa_user_extensions(struct xe_oa *oa, u64 extension, int ext_number
 	int err;
 	u32 idx;
 
-	if (XE_IOCTL_DBG(oa->xe, ext_number >= DRM_XE_OA_PROPERTY_MAX))
+	if (XE_IOCTL_DBG(oa->xe, ext_number >= __DRM_XE_OA_PROPERTY_MAX))
 		return -E2BIG;
 
 	err = __copy_from_user(&ext, address, sizeof(ext));
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 93e00be44b2d..6bc543db3e9d 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -1379,8 +1379,8 @@ struct drm_xe_wait_user_fence {
  * enum drm_xe_perf_type - Perf stream types
  */
 enum drm_xe_perf_type {
+	/** @DRM_XE_PERF_TYPE_OA: OA perf stream type */
 	DRM_XE_PERF_TYPE_OA,
-	__DRM_XE_PERF_TYPE_MAX, /* non-ABI */
 };
 
 /**
@@ -1612,8 +1612,8 @@ enum drm_xe_oa_property_id {
 	 */
 	DRM_XE_OA_PROPERTY_OA_ENGINE_INSTANCE,
 
-	/** @DRM_XE_OA_PROPERTY_MAX: non-ABI */
-	DRM_XE_OA_PROPERTY_MAX
+	/* private: non-ABI */
+	__DRM_XE_OA_PROPERTY_MAX
 };
 
 /**
-- 
2.41.0



More information about the Intel-xe mailing list