[PATCH] drm/xe/oa: Destroy the stream_lock mutex

Umesh Nerlige Ramappa umesh.nerlige.ramappa at intel.com
Fri Jun 28 16:58:57 UTC 2024


On Thu, Jun 27, 2024 at 10:21:25PM -0700, Ashutosh Dixit wrote:
>The mutex allocated in xe_oa_stream_init() was never previously
>destroyed. Do so now.
>
>Fixes: e936f885f1e9 ("drm/xe/oa/uapi: Expose OA stream fd")
>Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Since we are holding a drm reference, what is the logic behind using 
drmm_mutex_init() for some mutexes and just a mutex_init for this one?

Thanks,
Umesh

>---
> drivers/gpu/drm/xe/xe_oa.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
>index 6cc3f0217341..4188516a7816 100644
>--- a/drivers/gpu/drm/xe/xe_oa.c
>+++ b/drivers/gpu/drm/xe/xe_oa.c
>@@ -824,6 +824,8 @@ static void xe_oa_stream_destroy(struct xe_oa_stream *stream)
>
> 	WRITE_ONCE(u->exclusive_stream, NULL);
>
>+	mutex_destroy(&stream->stream_lock);
>+
> 	xe_oa_disable_metric_set(stream);
> 	xe_exec_queue_put(stream->k_exec_q);
>
>-- 
>2.41.0
>


More information about the Intel-xe mailing list