[PATCH] drm/xe/mcr: Avoid clobbering DSS steering

[Lucas De Marchi]

On Wed, Jun 26, 2024 at 02:05:37PM GMT, Matt Roper wrote:
>A couple copy/paste mistakes in the code that selects steering targets
>for OADDRM and INSTANCE0 unintentionally clobbered the steering target
>for DSS ranges in some cases.
>
>The OADDRM/INSTANCE0 values were also not assigned as intended, although
>that mistake wound up being harmless since the desired values for those
>specific ranges were '0' which the kzalloc of the GT structure should
>have already taken care of implicitly.
>
>Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_gt_mcr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
>index 386ac3269909..6d948a469126 100644
>--- a/drivers/gpu/drm/xe/xe_gt_mcr.c
>+++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
>@@ -342,7 +342,7 @@ static void init_steering_oaddrm(struct xe_gt *gt)
> 	else
> 		gt->steering[OADDRM].group_target = 1;
>
>-	gt->steering[DSS].instance_target = 0;		/* unused */
>+	gt->steering[OADDRM].instance_target = 0;	/* unused */
> }
>
> static void init_steering_sqidi_psmi(struct xe_gt *gt)
>@@ -357,8 +357,8 @@ static void init_steering_sqidi_psmi(struct xe_gt *gt)
>
> static void init_steering_inst0(struct xe_gt *gt)
> {
>-	gt->steering[DSS].group_target = 0;		/* unused */
>-	gt->steering[DSS].instance_target = 0;		/* unused */
>+	gt->steering[INSTANCE0].group_target = 0;	/* unused */
>+	gt->steering[INSTANCE0].instance_target = 0;	/* unused */
> }
>
> static const struct {
>-- 
>2.45.0
>