✗ CI.checkpatch: warning for series starting with [CI,1/4] drm/ttm: Add a flag to allow drivers to skip clear-on-free (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Sat Jun 29 20:35:25 UTC 2024
== Series Details ==
Series: series starting with [CI,1/4] drm/ttm: Add a flag to allow drivers to skip clear-on-free (rev2)
URL : https://patchwork.freedesktop.org/series/135538/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d8439cb70c24bfc730ad384bcb8e3ed0a003d161
Author: Nirmoy Das <nirmoy.das at intel.com>
Date: Fri Jun 28 21:38:46 2024 +0200
drm/xe/lnl: Offload system clear page activity to GPU
On LNL because of flat CCS, driver creates a migrate job to clear
CCS meta data. Extend that to also clear system pages using GPU.
Inform TTM to allocate pages without __GFP_ZERO to avoid double page
clearing by clearing out TTM_TT_FLAG_ZERO_ALLOC flag and set
TTM_TT_FLAG_CLEARED_ON_FREE while freeing to skip ttm pool's
clearn-on-free as XE now takes care of clearing pages.
To test the patch, I created a small test that tries to submit a job
after binding various sizes of buffer which shows good gains for larger
buffer. For lower buffer sizes, the result is not very reliable as the
results vary a lot.
Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
+ /mt/dim checkpatch 886eeb6d89b58f914ee5045fcac54b59a73d8299 drm-intel
094feda2db07 drm/ttm: Add a flag to allow drivers to skip clear-on-free
e5d5fe707c33 drm/xe/migrate: Parameterize ccs and bo data clear in xe_migrate_clear()
989efdb0fa02 drm/xe/migrate: Clear CCS when clearing bo with XE_FAST_COLOR_BLT
-:46: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#46: FILE: drivers/gpu/drm/xe/xe_migrate.c:1081:
+ if (xe_device_has_flat_ccs(xe) && clear_ccs && !(clear_bo_data &&
+ !is_fast_color_blt_cmd_for_clear(gt))) {
total: 0 errors, 0 warnings, 1 checks, 30 lines checked
d8439cb70c24 drm/xe/lnl: Offload system clear page activity to GPU
-:39: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#39: FILE: drivers/gpu/drm/xe/xe_bo.c:406:
+ uint32_t old_page_flags;
total: 0 errors, 0 warnings, 1 checks, 89 lines checked
More information about the Intel-xe
mailing list