[PATCH] drm/xe: Convert xe_pm_runtime_{get,put} to void and protect from recursion

Matthew Auld matthew.auld at intel.com
Fri Mar 1 17:44:55 UTC 2024


On 27/02/2024 18:35, Rodrigo Vivi wrote:
> With mem_access going away and pm_runtime getting called instead,
> we need to protect these against recursions.
> 
> For D3cold, the TTM migration helpers will call for the job execution.
> Jobs execution will be protected by direct runtime_pm calls, but they
> cannot be called again if we are already at a runtime suspend/resume
> transaction when evicting/restoring memory for D3Cold. So, we will check
> for the xe_pm_read_callback_task.

Does this need to be reworded? It looked like calling this for jobs 
wasn't going to work.

> 
> The put is asynchronous so there's no need to block it. However, for a
> proper balance, we need to ensure that the references are taken and
> restored regardless of the flow. So, let's convert them all to void and
> use some direct linux/pm_runtime functions.
> 
> Cc: Matthew Auld <matthew.auld at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-xe mailing list