[PATCH v3] replace 'grouped target' in Makefile with pattern rule

Lucas De Marchi lucas.demarchi at intel.com
Sun Mar 3 01:19:06 UTC 2024


On Sat, Mar 02, 2024 at 05:39:28PM +0200, Dafna Hirschfeld wrote:
>Since 'grouped target' is used only in 'make' 4.3, it should
>be avoided. Replace it with 'multi-target pattern rule' which
>has the same behavior.
>
>Signed-off-by: Dafna Hirschfeld <dhirschfeld at habana.ai>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>---
> drivers/gpu/drm/xe/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
>index 1a59c15f4d66..5a428ca00f10 100644
>--- a/drivers/gpu/drm/xe/Makefile
>+++ b/drivers/gpu/drm/xe/Makefile
>@@ -42,7 +42,8 @@ generated_oob := $(obj)/generated/xe_wa_oob.c $(obj)/generated/xe_wa_oob.h
> quiet_cmd_wa_oob = GEN     $(notdir $(generated_oob))
>       cmd_wa_oob = mkdir -p $(@D); $^ $(generated_oob)
>
>-$(generated_oob) &: $(obj)/xe_gen_wa_oob $(srctree)/$(src)/xe_wa_oob.rules
>+$(obj)/generated/%_wa_oob.c $(obj)/generated/%_wa_oob.h: $(obj)/xe_gen_wa_oob \
>+		 $(srctree)/$(src)/xe_wa_oob.rules
> 	$(call cmd,wa_oob)
>
> uses_generated_oob := \
>-- 
>2.34.1
>


More information about the Intel-xe mailing list