✗ CI.checkpatch: warning for series starting with [1/9] drm/xe: Remove useless mem_access during probe

[Patchwork]

== Series Details ==

Series: series starting with [1/9] drm/xe: Remove useless mem_access during probe
URL   : https://patchwork.freedesktop.org/series/130687/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
4dc7d0cc630cdd9ac56065b1a22afc329345a519
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 374acf809654a20a84a72789d2bf02adb92ae181
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date:   Mon Mar 4 13:21:54 2024 -0500

    drm/xe: Kill xe_device_mem_access_{get*,put}
    
    Let's simply convert all the current callers towards direct
    xe_pm_runtime access and remove this extra layer of indirection.
    
    v2: Convert all the current callers instead of a big refactor
    at once.
    
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch e8bc216572501440efb20e112bb5aa60599f1863 drm-intel
46c25999420b drm/xe: Remove useless mem_access during probe
e45295651aa2 drm/xe: Convert xe_gem_fault to use direct xe_pm_runtime calls
68f58363f70b drm/xe: Move lockdep protection from mem_access to xe_pm_runtime
db44a16825c3 drm/xe: Move xe_irq runtime suspend and resume out of lockdep
-:41: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#41: 
sufficient to protect any race and there's no counter part to get deadlocked

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
c46c8630842c drm/xe: Removing useless mem_access protection from runtime pm
80700c6de3c7 drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers
-:56: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: drivers/gpu/drm/xe/xe_pm.c:520:
+      bool ref;$

-:58: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#58: FILE: drivers/gpu/drm/xe/xe_pm.c:522:
+      ref = xe_pm_runtime_get_if_in_use(xe);$

-:60: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#60: FILE: drivers/gpu/drm/xe/xe_pm.c:524:
+      if (drm_WARN(&xe->drm, !ref, "Missing outer runtime PM protection\n"))$

-:60: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (6, 14)
#60: FILE: drivers/gpu/drm/xe/xe_pm.c:524:
+      if (drm_WARN(&xe->drm, !ref, "Missing outer runtime PM protection\n"))
+	      pm_runtime_get_noresume(xe->drm.dev);

total: 0 errors, 4 warnings, 0 checks, 41 lines checked
3371c5ffb687 drm/xe: Convert mem_access_if_ongoing to direct xe_pm_runtime_get_if_active
e1b132591f5f drm/xe: Ensure all the inner access are using the _noresume variant
374acf809654 drm/xe: Kill xe_device_mem_access_{get*,put}