[PATCH 8/9] drm/xe: Ensure all the inner access are using the _noresume variant
Matthew Auld
matthew.auld at intel.com
Tue Mar 5 11:14:43 UTC 2024
On 04/03/2024 18:21, Rodrigo Vivi wrote:
> At this point mem_access references should be only used as inner
> points of the execution and a get with synchronous resume previously
> called at an outer point.
>
> So, before killing mem_acces in favor of direct accsess, let's
> ensure that we first convert them towards the new _noresume
> variant that will WARN us if no inner caller happened.
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
I guess let's see what CI says.
Reviewed-by: Matthew Auld <matthew.auld at intel.com>
> ---
> drivers/gpu/drm/xe/xe_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 6c7850dd70b5..58815e9bf242 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -671,7 +671,7 @@ void xe_device_mem_access_get(struct xe_device *xe)
> if (xe_pm_read_callback_task(xe) == current)
> return;
>
> - xe_pm_runtime_get(xe);
> + xe_pm_runtime_get_noresume(xe);
> ref = atomic_inc_return(&xe->mem_access.ref);
>
> xe_assert(xe, ref != S32_MAX);
More information about the Intel-xe
mailing list