✗ CI.checkpatch: warning for um: Minor fixes and cleanups

[Patchwork]

== Series Details ==

Series: um: Minor fixes and cleanups
URL   : https://patchwork.freedesktop.org/series/130801/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
7d6fb25447372de10c7d82d450bf95e4b2e2a0ab
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d2e66e675ab22c6fc356d3488d2003697080a13f
Author: Tiwei Bie <tiwei.btw at antgroup.com>
Date:   Wed Mar 6 18:19:25 2024 +0800

    um: Fix -Wmissing-prototypes warnings for __warp_* and foo
    
    These functions are not called explicitly. Let's just workaround
    the -Wmissing-prototypes warnings by declaring them locally similar
    to what was done in arch/x86/kernel/asm-offsets_32.c.
    
    This will address below -Wmissing-prototypes warnings:
    
    ./arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
    arch/um/os-Linux/main.c:187:7: warning: no previous prototype for ‘__wrap_malloc’ [-Wmissing-prototypes]
    arch/um/os-Linux/main.c:208:7: warning: no previous prototype for ‘__wrap_calloc’ [-Wmissing-prototypes]
    arch/um/os-Linux/main.c:222:6: warning: no previous prototype for ‘__wrap_free’ [-Wmissing-prototypes]
    arch/x86/um/user-offsets.c:17:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
    
    Signed-off-by: Tiwei Bie <tiwei.btw at antgroup.com>
+ /mt/dim checkpatch 6e50187af603728329f9d3c3a53ad162d7eda9a4 drm-intel
bd81ab775927 um: Make local functions and variables static
-:11: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#11: 
warning: no previous prototype for ‘fork_handler’ [-Wmissing-prototypes]

total: 0 errors, 1 warnings, 0 checks, 136 lines checked
63ab129c2c35 um: Fix the declaration of vfree
-:21: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#21: FILE: arch/um/include/shared/um_malloc.h:15:
+extern void vfree(const void *ptr);

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
f0a6c5bae70b um: Remove unused functions
bf472d37b42f um: Fix the return type of __switch_to
a3eabba75f7e um: Add missing headers
-:96: CHECK:ARCH_INCLUDE_LINUX: Consider using #include <linux/mmu_context.h> instead of <asm/mmu_context.h>
#96: FILE: arch/um/kernel/skas/mmu.c:13:
+#include <asm/mmu_context.h>

-:132: CHECK:ARCH_INCLUDE_LINUX: Consider using #include <linux/mmu_context.h> instead of <asm/mmu_context.h>
#132: FILE: arch/um/kernel/tlb.c:11:
+#include <asm/mmu_context.h>

total: 0 errors, 0 warnings, 2 checks, 104 lines checked
fe467ce3bc98 um: Stop tracking host PID in cpu_tasks
4f445f0dbbf4 um: Move declarations to proper headers
-:32: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#32: FILE: arch/um/include/asm/ptrace-generic.h:39:
+extern int poke_user(struct task_struct *child, long addr, long data);

-:33: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#33: FILE: arch/um/include/asm/ptrace-generic.h:40:
+extern int peek_user(struct task_struct *child, long addr, long data);

-:46: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#46: FILE: arch/um/include/shared/kern_util.h:44:
+extern int parse_iomem(char *str, int *add);

-:106: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#106: FILE: arch/um/kernel/um_arch.h:14:
+extern int __init read_initrd(void);

-:129: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#129: FILE: arch/x86/um/asm/ptrace.h:57:
+extern int arch_switch_tls(struct task_struct *to);

-:141: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#141: FILE: arch/x86/um/asm/ptrace.h:91:
+extern void arch_switch_to(struct task_struct *to);

total: 0 errors, 0 warnings, 6 checks, 86 lines checked
4e4cfcf3aae4 um: Fix -Wmissing-prototypes warnings for text_poke*
d2e66e675ab2 um: Fix -Wmissing-prototypes warnings for __warp_* and foo
-:34: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#34: FILE: arch/um/os-Linux/main.c:190:
+void __wrap_free(void *ptr);

total: 0 errors, 1 warnings, 0 checks, 29 lines checked