✗ CI.checkpatch: warning for series starting with [CI,only,1/3] drm: Add drm_vblank_work_flush_all().
Patchwork
patchwork at emeril.freedesktop.org
Wed Mar 6 13:45:48 UTC 2024
== Series Details ==
Series: series starting with [CI,only,1/3] drm: Add drm_vblank_work_flush_all().
URL : https://patchwork.freedesktop.org/series/130809/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
7d6fb25447372de10c7d82d450bf95e4b2e2a0ab
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a878c5086761e0f1200b7d018c4643349122c88a
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date: Wed Mar 6 14:40:50 2024 +0100
drm/i915: Use the same vblank worker for atomic unpin
In case of legacy cursor update, the cursor VMA needs to be unpinned
only after vblank. This exceeds the lifetime of the whole atomic commit.
Any trick I attempted to keep the atomic commit alive didn't work, as
drm_atomic_helper_setup_commit() force throttles on any old commit that
wasn't cleaned up.
The only option remaining is to remove the plane from the atomic commit,
and use the same path as the legacy cursor update to clean the state
after vblank.
Changes since previous version:
- Call the memset for plane state immediately when scheduling vblank,
this prevents a use-after-free in cursor cleanup.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch aefffa61304243e22ad6ae8c74150a021a859017 drm-intel
7c638af2478e drm: Add drm_vblank_work_flush_all().
-:33: WARNING:WAITQUEUE_ACTIVE: waitqueue_active without comment
#33: FILE: drivers/gpu/drm/drm_vblank_work.c:249:
+ waitqueue_active(&vblank->work_wait_queue),
total: 0 errors, 1 warnings, 0 checks, 41 lines checked
5fdac623e1fe drm/i915: Use vblank worker to unpin old legacy cursor fb safely
a878c5086761 drm/i915: Use the same vblank worker for atomic unpin
-:107: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#107: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:641:
+ drm_crtc_accurate_vblank_count(&crtc->base) + 1,
-:110: WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#110: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:644:
+ /* Remove plane from atomic state, cleanup/free is done from vblank worker. */
total: 0 errors, 2 warnings, 0 checks, 98 lines checked
More information about the Intel-xe
mailing list