✗ CI.checkpatch: warning for series starting with [01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 7 01:02:57 UTC 2024


== Series Details ==

Series: series starting with [01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use
URL   : https://patchwork.freedesktop.org/series/130839/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
7d6fb25447372de10c7d82d450bf95e4b2e2a0ab
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit fe9ef4db52717687db6289f438943815c54cd10e
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date:   Wed Mar 6 19:15:54 2024 -0500

    drm/xe: Kill xe_device_mem_access_{get*,put}
    
    Let's simply convert all the current callers towards direct
    xe_pm_runtime access and remove this extra layer of indirection.
    
    v2: Convert all the current callers instead of a big refactor
    at once.
    
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Reviewed-by: Matthew Auld <matthew.auld at intel.com>
+ /mt/dim checkpatch c9b9b8d4449209d2451127f98cdfe2b99bec3da7 drm-intel
5d8b6cf556d7 drm/i915/display: convert inner wakeref get towards get_if_in_use
a57843656f58 drm/xe: Move lockdep protection from mem_access to xe_pm_runtime
209efb548ff4 drm/xe: Convert GSC HDCP from mem_access to direct xe_pm_runtime calls
7f4933cbbf7d drm/xe: Remove useless mem_access during probe
c331526ecec7 drm/xe: Convert xe_gem_fault to use direct xe_pm_runtime calls
bee323988b62 drm/xe: Removing extra mem_access protection from runtime pm
41d56164ec80 drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers
-:57: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#57: FILE: drivers/gpu/drm/xe/xe_pm.c:517:
+      bool ref;$

-:59: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#59: FILE: drivers/gpu/drm/xe/xe_pm.c:519:
+      ref = xe_pm_runtime_get_if_in_use(xe);$

-:61: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#61: FILE: drivers/gpu/drm/xe/xe_pm.c:521:
+      if (drm_WARN(&xe->drm, !ref, "Missing outer runtime PM protection\n"))$

-:61: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (6, 14)
#61: FILE: drivers/gpu/drm/xe/xe_pm.c:521:
+      if (drm_WARN(&xe->drm, !ref, "Missing outer runtime PM protection\n"))
+	      pm_runtime_get_noresume(xe->drm.dev);

total: 0 errors, 4 warnings, 0 checks, 41 lines checked
d42e64833c0b drm/xe: Convert mem_access_if_ongoing to direct xe_pm_runtime_get_if_active
64e419269fec drm/xe: Ensure all the inner access are using the _noresume variant
fe9ef4db5271 drm/xe: Kill xe_device_mem_access_{get*,put}




More information about the Intel-xe mailing list