[PATCH 4/4] drm/xe: Nuke EXEC_QUEUE_FLAG_PERSISTENT

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Thu Mar 7 10:54:17 UTC 2024


For patch 2 with the errno inversion fixed, and 1 and 4:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

On 2024-03-04 15:05, José Roberto de Souza wrote:
> This is a left over of commit f1a9abc0cf31 ("drm/xe/uapi: Remove support for persistent exec_queues").
> 
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>   drivers/gpu/drm/xe/xe_exec_queue_types.h | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> index 62b3d9d1d7cdd..9cc689f50db00 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> @@ -76,14 +76,12 @@ struct xe_exec_queue {
>   #define EXEC_QUEUE_FLAG_KERNEL			BIT(1)
>   /* kernel engine only destroyed at driver unload */
>   #define EXEC_QUEUE_FLAG_PERMANENT		BIT(2)
> -/* queue keeps running pending jobs after destroy ioctl */
> -#define EXEC_QUEUE_FLAG_PERSISTENT		BIT(3)
>   /* for VM jobs. Caller needs to hold rpm ref when creating queue with this flag */
> -#define EXEC_QUEUE_FLAG_VM			BIT(4)
> +#define EXEC_QUEUE_FLAG_VM			BIT(3)
>   /* child of VM queue for multi-tile VM jobs */
> -#define EXEC_QUEUE_FLAG_BIND_ENGINE_CHILD	BIT(5)
> +#define EXEC_QUEUE_FLAG_BIND_ENGINE_CHILD	BIT(4)
>   /* kernel exec_queue only, set priority to highest level */
> -#define EXEC_QUEUE_FLAG_HIGH_PRIORITY		BIT(6)
> +#define EXEC_QUEUE_FLAG_HIGH_PRIORITY		BIT(5)
>   
>   	/**
>   	 * @flags: flags for this exec queue, should statically setup aside from ban


More information about the Intel-xe mailing list