[PATCH] drm/xe/hdcp: Fix condition for hdcp gsc cs requirement

Lucas De Marchi lucas.demarchi at intel.com
Fri Mar 8 15:23:37 UTC 2024


On Fri, Mar 08, 2024 at 07:18:18PM +0530, Suraj Kandpal wrote:
>Add condition for check of hdcp gsc cs requirement rather than
>assuming gsc cs to always be required when xe is loaded. It is not
>required for Gen pre-MTL

"Gen pre-MTL" is not a thing. There is no mention to "gen" in xe and I'd
like to keep it clean. Please refer to it as display version (like code
is doing) or just the platform name. With that small reword,

|	Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>
>Fixes: 152f2df954d8 ("drm/xe/hdcp: Enable HDCP for XE")
>Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
>---
> drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
>index dcde1d0ac1f8..25c73602ef55 100644
>--- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
>+++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
>@@ -32,7 +32,7 @@ struct intel_hdcp_gsc_message {
>
> bool intel_hdcp_gsc_cs_required(struct xe_device *xe)
> {
>-	return true;
>+	return DISPLAY_VER(xe) >= 14;
> }
>
> bool intel_hdcp_gsc_check_status(struct xe_device *xe)
>-- 
>2.43.2
>


More information about the Intel-xe mailing list