[PATCH 2/3] drm/xe/vf: Remove lmtt->ops null check in xe_lmtt_estimate_pt_size

[Lucas De Marchi]

On Mon, Mar 11, 2024 at 02:13:31PM +0100, Michal Wajdeczko wrote:
>>> and/or mark the tool as a false positive?!
>
>I would make another step and just fix the tool to be run against the
>production code, without xe_assert() being enabled, as all our
>xe_asserts() are to some extend "redundant" with the production code,
>and the tool will complain not only against extra/missed NULL checks but
>also against other conditions that will look like 'not-possible' at
>given code snapshot, but the purpose of xe_asserts is to protect
>ourselves against future code updates/changes that current code might
>not be prepared to or it has different assumptions.

and at the same time, we shouldn't rely on having xe_assert() in place
to have the right behavior as it won't always be there. So yes, please
use the config that has xe_assert as a nop.

Lucas De Marchi