[PATCH v2 2/2] drm/xe/xe_exec : In xe_exec_ioctl remove deadcode
Himal Prasad Ghimiray
himal.prasad.ghimiray at intel.com
Wed Mar 13 15:05:45 UTC 2024
At label err_unlock_list the condition write_label will never be true.
Remove the deadcode line for write_label true.
Reported by static analyzer.
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay at intel.com>
Cc: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
---
drivers/gpu/drm/xe/xe_exec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_exec.c b/drivers/gpu/drm/xe/xe_exec.c
index 952496c6260d..acc066e405d0 100644
--- a/drivers/gpu/drm/xe/xe_exec.c
+++ b/drivers/gpu/drm/xe/xe_exec.c
@@ -380,10 +380,7 @@ int xe_exec_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
err_exec:
drm_exec_fini(exec);
err_unlock_list:
- if (write_locked)
- up_write(&vm->lock);
- else
- up_read(&vm->lock);
+ up_read(&vm->lock);
if (err == -EAGAIN && !skip_retry)
goto retry;
err_syncs:
--
2.25.1
More information about the Intel-xe
mailing list