✗ CI.checkpatch: warning for series starting with [1/3] drm/xe: Introduce a simple wedged state

Patchwork patchwork at emeril.freedesktop.org
Wed Mar 13 20:01:05 UTC 2024


== Series Details ==

Series: series starting with [1/3] drm/xe: Introduce a simple wedged state
URL   : https://patchwork.freedesktop.org/series/131097/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 6c105fa6848bdb98740475d07f3aea22ed6ba887
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date:   Wed Mar 13 15:54:59 2024 -0400

    drm/xe: Force wedged state and block GT reset upon any GPU hang
    
    In many validation situations when debugging GPU Hangs,
    it is useful to preserve the GT situation from the moment
    that the timeout occurred.
    
    This patch introduces a module parameter that could be used
    on situations like this.
    
    If xe.wedged module parameter is set to 2, Xe will be declared
    wedged on every single execution timeout (a.k.a. GPU hang) right
    after devcoredump snapshot capture and without attempting any
    kind of GT reset and blocking entirely any kind of execution.
    
    Cc: Alan Previn <alan.previn.teres.alexis at intel.com>
    Cc: Himanshu Somaiya <himanshu.somaiya at intel.com>
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch a636de6272a7883e73563d5049a48df02e67bf70 drm-intel
7e945b6b3924 drm/xe: Introduce a simple wedged state
-:91: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#91: FILE: drivers/gpu/drm/xe/xe_gt.c:636:
+	if (xe_device_wedged(gt_to_xe(gt)))
+	    return -ECANCELED;

-:92: WARNING:TABSTOP: Statements should start on a tabstop
#92: FILE: drivers/gpu/drm/xe/xe_gt.c:637:
+	    return -ECANCELED;

-:113: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#113: FILE: drivers/gpu/drm/xe/xe_migrate.c:716:
+	if (xe_device_wedged(xe))
+	    return ERR_PTR(-ECANCELED);

-:114: WARNING:TABSTOP: Statements should start on a tabstop
#114: FILE: drivers/gpu/drm/xe/xe_migrate.c:717:
+	    return ERR_PTR(-ECANCELED);

-:123: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#123: FILE: drivers/gpu/drm/xe/xe_migrate.c:992:
+	if (xe_device_wedged(xe))
+	    return ERR_PTR(-ECANCELED);

-:124: WARNING:TABSTOP: Statements should start on a tabstop
#124: FILE: drivers/gpu/drm/xe/xe_migrate.c:993:
+	    return ERR_PTR(-ECANCELED);

total: 0 errors, 6 warnings, 0 checks, 79 lines checked
514052b68dc5 drm/xe: declare wedged and abort probe upon GuC load failure
6c105fa6848b drm/xe: Force wedged state and block GT reset upon any GPU hang




More information about the Intel-xe mailing list