[PATCH] drm/xe: Remove unused xe_bo->props struct

Lucas De Marchi lucas.demarchi at intel.com
Thu Mar 14 04:24:18 UTC 2024


On Mon, Mar 11, 2024 at 12:49:40PM -0400, Rodrigo Vivi wrote:
>On Mon, Mar 11, 2024 at 11:43:54AM -0500, Lucas De Marchi wrote:
>> On Mon, Mar 11, 2024 at 12:33:29PM -0400, Rodrigo Vivi wrote:
>> > On Mon, Mar 11, 2024 at 04:11:59PM +0100, Nirmoy Das wrote:
>> > > Property struct is not being used so remove it and related dead code.
>> > >
>> > > Fixes: ddfa2d6a846a ("drm/xe/uapi: Kill VM_MADVISE IOCTL")
>> > > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> > > Cc: "Thomas Hellström" <thomas.hellstrom at linux.intel.com>
>> > > Cc: intel-xe at lists.freedesktop.org
>> > > Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
>> >
>> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>>
>> afaics this is only removing dead code since it was not possible to set
>> those props. I'm wondering if we should really keep the Fixes since
>> technically we don't need this in 6.8 or 6.9. Thoughts?
>
>good point.
>Fixes tag can be avoided here.
>And perhaps just cheery-pick later to fixes if some future patch
>conflict with this.
>
>But also if we are in later states of -fixes flow we can drop
>the patch itself when we are cherry-picking the fixes.
>
>and if we are in earlier stages of the fixes there's no problem
>on sending a clean up up.
>
>Up to you there.

ok, let's keep the Fixes.

pushed to drm-xe-next, thanks.

Lucas De Marchi

>
>>
>> Lucas De Marchi


More information about the Intel-xe mailing list