✗ CI.checkpatch: warning for drm/i915/display: DMC wakelock implementation (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/display: DMC wakelock implementation (rev3)
URL   : https://patchwork.freedesktop.org/series/128628/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 593b857a8ec36ec99337d3dc241a0f6e66e5f1e2
Author: Luca Coelho <luciano.coelho at intel.com>
Date:   Thu Mar 14 09:37:52 2024 +0200

    drm/i915/display: tie DMC wakelock to DC5/6 state transitions
    
    We only need DMC wakelocks when we allow DC5 and DC6 states.  Add the
    calls to enable and disable DMC wakelock accordingly.
    
    Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
+ /mt/dim checkpatch 96e47e3f3a5952e104d56352872becdc0048d26e drm-intel
6ca729037461 drm/i915/display: add support for DMC wakelocks
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:237: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#237: 
new file mode 100644

-:242: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_dmc_wl.c', please use '//' instead
#242: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:1:
+/* SPDX-License-Identifier: MIT */

-:242: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#242: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:1:
+/* SPDX-License-Identifier: MIT */

-:381: WARNING:RETURN_VOID: void function return statements are not generally useful
#381: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:140:
+	return;
+}

-:410: WARNING:RETURN_VOID: void function return statements are not generally useful
#410: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:169:
+	return;
+}

-:458: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#458: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:217:
+	if (WARN_RATELIMIT(!refcount_read(&wl->refcount),
+		    "Tried to put wakelock with refcount zero\n"))

-:493: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#493: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.h:18:
+	spinlock_t lock;

total: 0 errors, 5 warnings, 2 checks, 452 lines checked
017bf2c4ff22 drm/i915/display: don't allow DMC wakelock on older hardware
e8bffcb94860 drm/i915/display: add module parameter to enable DMC wakelock
-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/display/intel_display_params.c:120:
+intel_display_param_named_unsafe(enable_dmc_wl, bool, 0400,
+	"Enable DMC wakelock "

total: 0 errors, 0 warnings, 1 checks, 54 lines checked
593b857a8ec3 drm/i915/display: tie DMC wakelock to DC5/6 state transitions