✗ CI.checkpatch: warning for drm/xe: Add helper macro to loop each DSS

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 14 16:06:57 UTC 2024


== Series Details ==

Series: drm/xe: Add helper macro to loop each DSS
URL   : https://patchwork.freedesktop.org/series/131144/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 091118713bd7ee4e546a6deaf0598c2669966ef8
Author: Zhanjun Dong <zhanjun.dong at intel.com>
Date:   Thu Mar 14 09:00:26 2024 -0700

    drm/xe: Add helper macro to loop each DSS
    
    Add helper macro to loop each DSS. This is a precursor patch to allow
    for easier iteration through MCR registers and other per-DSS uses.
    
    Signed-off-by: Zhanjun Dong <zhanjun.dong at intel.com>
+ /mt/dim checkpatch 6ef6a88b113169e4637be283b2514cfed22f8d99 drm-intel
091118713bd7 drm/xe: Add helper macro to loop each DSS
-:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt' - possible side-effects?
#88: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:36:
+#define for_each_dss(dss, gt) \
+	for_each_or_bit((dss), \
+			(gt)->fuse_topo.g_dss_mask, \
+			(gt)->fuse_topo.c_dss_mask, \
+			XE_MAX_DSS_FUSE_BITS)

-:102: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#102: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:50:
+#define for_each_dss_steering(dss, gt, group, instance) \
+	for_each_dss((dss), (gt)) \
+		for_each_if((xe_gt_mcr_get_dss_steering((gt), (dss), &(group), &(instance)), true))

-:102: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss' - possible side-effects?
#102: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:50:
+#define for_each_dss_steering(dss, gt, group, instance) \
+	for_each_dss((dss), (gt)) \
+		for_each_if((xe_gt_mcr_get_dss_steering((gt), (dss), &(group), &(instance)), true))

-:102: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt' - possible side-effects?
#102: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:50:
+#define for_each_dss_steering(dss, gt, group, instance) \
+	for_each_dss((dss), (gt)) \
+		for_each_if((xe_gt_mcr_get_dss_steering((gt), (dss), &(group), &(instance)), true))

-:135: WARNING:NEW_TYPEDEFS: do not add new typedefs
#135: FILE: drivers/gpu/drm/xe/xe_gt_types.h:32:
+typedef unsigned long xe_dss_mask_t[BITS_TO_LONGS(XE_MAX_DSS_FUSE_BITS)];

-:136: WARNING:NEW_TYPEDEFS: do not add new typedefs
#136: FILE: drivers/gpu/drm/xe/xe_gt_types.h:33:
+typedef unsigned long xe_eu_mask_t[BITS_TO_LONGS(XE_MAX_EU_FUSE_BITS)];

total: 1 errors, 2 warnings, 3 checks, 107 lines checked




More information about the Intel-xe mailing list