[PATCH] drm/xe/guc_submit: use jiffies for job timeout

Matthew Brost matthew.brost at intel.com
Thu Mar 14 16:15:25 UTC 2024


On Thu, Mar 14, 2024 at 12:15:55PM +0000, Matthew Auld wrote:
> drm_sched_init() expects jiffies for the timeout, but here we are
> passing the timeout in ms. Convert to jiffies instead.
> 
> Fixes: eef55700f302 ("drm/xe: Add sysfs for default engine scheduler properties")
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Matthew Brost <matthew.brost at intel.com>

Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 19efdb2f881f..82c955a2a15c 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1226,7 +1226,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
>  	init_waitqueue_head(&ge->suspend_wait);
>  
>  	timeout = (q->vm && xe_vm_in_lr_mode(q->vm)) ? MAX_SCHEDULE_TIMEOUT :
> -		  q->sched_props.job_timeout_ms;
> +		  msecs_to_jiffies(q->sched_props.job_timeout_ms);
>  	err = xe_sched_init(&ge->sched, &drm_sched_ops, &xe_sched_ops,
>  			    get_submit_wq(guc),
>  			    q->lrc[0].ring.size / MAX_JOB_SIZE_BYTES, 64,
> -- 
> 2.44.0
> 


More information about the Intel-xe mailing list